simplify constructor

Author: julienrbrt

apps/evm/cmd/run.go

@@ -169,7 +169,7 @@ func createSequencer(
 			return nil, fmt.Errorf("based sequencer mode requires aggregator mode to be enabled")
 		}
 
-		basedSeq, err := based.NewBasedSequencer(ctx, fiRetriever, da, datastore, nodeConfig, genesis, logger)
+		basedSeq, err := based.NewBasedSequencer(ctx, fiRetriever, da, datastore, genesis, logger)
 		if err != nil {
 			return nil, fmt.Errorf("failed to create based sequencer: %w", err)
 		}

apps/grpc/cmd/run.go

@@ -131,7 +131,7 @@ func createSequencer(
 			return nil, fmt.Errorf("based sequencer mode requires aggregator mode to be enabled")
 		}
 
-		basedSeq, err := based.NewBasedSequencer(ctx, fiRetriever, da, datastore, nodeConfig, genesis, logger)
+		basedSeq, err := based.NewBasedSequencer(ctx, fiRetriever, da, datastore, genesis, logger)
 		if err != nil {
 			return nil, fmt.Errorf("failed to create based sequencer: %w", err)
 		}

apps/testapp/cmd/run.go

@@ -131,7 +131,7 @@ func createSequencer(
 			return nil, fmt.Errorf("based sequencer mode requires aggregator mode to be enabled")
 		}
 
-		basedSeq, err := based.NewBasedSequencer(ctx, fiRetriever, da, datastore, nodeConfig, genesis, logger)
+		basedSeq, err := based.NewBasedSequencer(ctx, fiRetriever, da, datastore, genesis, logger)
 		if err != nil {
 			return nil, fmt.Errorf("failed to create based sequencer: %w", err)
 		}

sequencers/based/sequencer.go

@@ -13,7 +13,6 @@ import (
 	"github.com/evstack/ev-node/block"
 	coreda "github.com/evstack/ev-node/core/da"
 	coresequencer "github.com/evstack/ev-node/core/sequencer"
-	"github.com/evstack/ev-node/pkg/config"
 	"github.com/evstack/ev-node/pkg/genesis"
 	seqcommon "github.com/evstack/ev-node/sequencers/common"
 )
@@ -31,7 +30,6 @@ var _ coresequencer.Sequencer = (*BasedSequencer)(nil)
 type BasedSequencer struct {
 	fiRetriever ForcedInclusionRetriever
 	da          coreda.DA
-	config      config.Config
 	genesis     genesis.Genesis
 	logger      zerolog.Logger
 
@@ -49,14 +47,12 @@ func NewBasedSequencer(
 	fiRetriever ForcedInclusionRetriever,
 	da coreda.DA,
 	db ds.Batching,
-	config config.Config,
 	genesis genesis.Genesis,
 	logger zerolog.Logger,
 ) (*BasedSequencer, error) {
 	bs := &BasedSequencer{
 		fiRetriever:     fiRetriever,
 		da:              da,
-		config:          config,
 		genesis:         genesis,
 		logger:          logger.With().Str("component", "based_sequencer").Logger(),
 		checkpointStore: seqcommon.NewCheckpointStore(db, ds.NewKey("/based/checkpoint")),

sequencers/based/sequencer_test.go

@@ -90,7 +90,7 @@ func createTestSequencer(t *testing.T, mockDA *MockDA, cfg config.Config, gen ge
 	// Create in-memory datastore
 	db := syncds.MutexWrap(ds.NewMapDatastore())
 
-	seq, err := NewBasedSequencer(context.Background(), fiRetriever, mockDA, db, cfg, gen, zerolog.Nop())
+	seq, err := NewBasedSequencer(context.Background(), fiRetriever, mockDA, db, gen, zerolog.Nop())
 	require.NoError(t, err)
 	return seq
 }
@@ -223,7 +223,7 @@ func TestBasedSequencer_GetNextBatch_NotConfigured(t *testing.T) {
 	// Create in-memory datastore
 	db := syncds.MutexWrap(ds.NewMapDatastore())
 
-	seq, err := NewBasedSequencer(context.Background(), fiRetriever, mockDA, db, cfg, gen, zerolog.Nop())
+	seq, err := NewBasedSequencer(context.Background(), fiRetriever, mockDA, db, gen, zerolog.Nop())
 	require.NoError(t, err)
 
 	req := coresequencer.GetNextBatchRequest{
@@ -580,7 +580,7 @@ func TestBasedSequencer_CheckpointPersistence(t *testing.T) {
 	daClient := block.NewDAClient(mockDA, cfg, zerolog.Nop())
 	fiRetriever := block.NewForcedInclusionRetriever(daClient, gen, zerolog.Nop())
 
-	seq1, err := NewBasedSequencer(context.Background(), fiRetriever, mockDA, db, cfg, gen, zerolog.Nop())
+	seq1, err := NewBasedSequencer(context.Background(), fiRetriever, mockDA, db, gen, zerolog.Nop())
 	require.NoError(t, err)
 
 	req := coresequencer.GetNextBatchRequest{
@@ -595,7 +595,7 @@ func TestBasedSequencer_CheckpointPersistence(t *testing.T) {
 	assert.Equal(t, 2, len(resp.Batch.Transactions))
 
 	// Create a new sequencer with the same datastore (simulating restart)
-	seq2, err := NewBasedSequencer(context.Background(), fiRetriever, mockDA, db, cfg, gen, zerolog.Nop())
+	seq2, err := NewBasedSequencer(context.Background(), fiRetriever, mockDA, db, gen, zerolog.Nop())
 	require.NoError(t, err)
 
 	// Checkpoint should be loaded from DB

sequencers/single/doc.go

@@ -1,3 +1,4 @@
+// Package single implements a single sequencer.
 package single
 
 import (