Skip to content

link-to benchmarks do not run against canary ember #34

@cowboyd

Description

@cowboyd

The APIs which the benchmark uses to create a router appear to no longer work. At first blush, It appears that its the lack of a container with properly registered dependencies. When running the link-to/active benchmark, you see this.

TypeError: Cannot read property 'recognizer' of undefined
    at isActiveForRoute (http://builds.emberjs.com/canary/ember.prod.js:20441:35)
    at computeActive (http://builds.emberjs.com/canary/ember.prod.js:20428:13)
    at computeLinkViewActive (http://builds.emberjs.com/canary/ember.prod.js:20144:16)
    at Descriptor.ComputedPropertyPrototype.get (http://builds.emberjs.com/canary/ember.prod.js:10587:28)
    at get (http://builds.emberjs.com/canary/ember.prod.js:16097:21)
    at __exports__.default.Mixin.create.get (http://builds.emberjs.com/canary/ember.prod.js:31892:16)
    at Benchmark.uid1420732482868createFunction [as compiled] (<anonymous>:15:66)
    at clock (http://localhost:4200/assets/test-client.js:3015:32)
    at clock (http://localhost:4200/assets/test-client.js:3223:18)
    at cycle (http://localhost:4200/assets/test-client.js:3413:47)

It appeared that the internal router.js router is not being initialized.

We were able to solve this problem, but ran issue after issue most seemingly related to the lack of properly initialized container, so we figured it was time to report it and see if there were a cleaner solution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions