Basic wallet full tests

Author: everoddandeven

.github/workflows/test.yml

@@ -114,7 +114,7 @@ jobs:
 
     - name: Run tests
       env:
-        REGTEST: "true"
+        IN_CONTAINER: "true"
       run: |
         pytest
 

tests/config/config.ini

@@ -2,7 +2,7 @@
 test_non_relays=True
 lite_mode=False
 test_notifications=True
-network_type=mainnet
+network_type=regtest
 auto_connect_timeout_ms=3000
 
 [daemon]

tests/test_monero_daemon_rpc.py

@@ -14,7 +14,6 @@
 from utils import TestUtils as Utils, TestContext, BinaryBlockContext, MiningUtils
 
 logger: logging.Logger = logging.getLogger(__name__)
-Utils.load_config()
 
 
 class TestMoneroDaemonRpc:

tests/test_monero_wallet_full.py

@@ -1,26 +1,23 @@
 import pytest
-import os
 
 from typing import Optional
 from typing_extensions import override
 from monero import (
-    MoneroWalletFull, MoneroWalletConfig, MoneroNetworkType, MoneroAccount,
+    MoneroWalletFull, MoneroWalletConfig, MoneroAccount,
     MoneroSubaddress, MoneroDaemonRpc, MoneroWallet
 )
 
 from utils import TestUtils as Utils
 from test_monero_wallet_common import BaseTestMoneroWallet
 
-Utils.load_config()
 
-
-# TODO enable full wallet tests
-@pytest.mark.skipif(True, reason="TODO")
 class TestMoneroWalletFull(BaseTestMoneroWallet):
 
     _daemon: MoneroDaemonRpc = Utils.get_daemon_rpc()
     _wallet: MoneroWalletFull = Utils.get_wallet_full() # type: ignore
 
+    #region Overrides
+
     @override
     def _create_wallet(self, config: Optional[MoneroWalletConfig], start_syncing: bool = True):
         # assign defaults
@@ -82,33 +79,13 @@ def _get_seed_languages(self) -> list[str]:
     def get_test_wallet(self) -> MoneroWallet:
         return Utils.get_wallet_full()
 
-    def test_wallet_creation_and_close(self):
-        config_keys = MoneroWalletConfig()
-        config_keys.language = "English"
-        config_keys.network_type = MoneroNetworkType.TESTNET
-        keys_wallet = MoneroWalletFull.create_wallet(config_keys)
-        seed = keys_wallet.get_seed()
-
-        config = MoneroWalletConfig()
-        config.path = "test_wallet_sync"
-        config.password = "password"
-        config.network_type = MoneroNetworkType.TESTNET
-        config.restore_height = 0
-        config.seed = seed
-        config.language = "English"
+    #endregion
 
-        wallet = MoneroWalletFull.create_wallet(config)
-        assert wallet.is_view_only() is False
-        wallet.close(save=False)
-
-        for ext in ["", ".keys", ".address.txt"]:
-            try:
-                os.remove(f"test_wallet_sync{ext}")
-            except FileNotFoundError:
-                pass
+    #region Tests
 
     # Can create a subaddress with and without a label
     @pytest.mark.skipif(Utils.TEST_NON_RELAYS is False, reason="TEST_NON_RELAYS disabled")
+    @override
     def test_create_subaddress(self):
         # create subaddresses across accounts
         accounts: list[MoneroAccount] = self._wallet.get_accounts()
@@ -138,3 +115,84 @@ def test_create_subaddress(self):
             Utils.assert_equals(len(subaddresses), len(subaddresses_new) - 1)
             Utils.assert_equals(subaddress, subaddresses_new[len(subaddresses_new) - 1])
             account_idx += 1
+
+    #endregion
+
+    #region Disabled Tests
+
+    @pytest.mark.skipif(Utils.REGTEST, reason="Cannot retrieve accurate height by date from regtest fakechain")
+    @override
+    def test_get_height_by_date(self):
+        return super().test_get_height_by_date()
+
+    @pytest.mark.skip(reason="TODO")
+    @override
+    def test_create_wallet_random(self) -> None:
+        return super().test_create_wallet_random()
+
+    @pytest.mark.skip(reason="TODO")
+    @override
+    def test_create_wallet_from_seed(self, test_config: BaseTestMoneroWallet.Config) -> None:
+        return super().test_create_wallet_from_seed(test_config)
+
+    @pytest.mark.skip(reason="TODO")
+    @override
+    def test_create_wallet_from_keys(self) -> None:
+        return super().test_create_wallet_from_keys()
+
+    @pytest.mark.skip(reason="TODO")
+    @override
+    def test_create_wallet_from_seed_with_offset(self) -> None:
+        return super().test_create_wallet_from_seed_with_offset()
+
+    @pytest.mark.skip(reason="TODO")
+    @override
+    def test_wallet_equality_ground_truth(self):
+        return super().test_wallet_equality_ground_truth()
+
+    @pytest.mark.skip(reason="TODO")
+    @override
+    def test_get_payment_uri(self):
+        return super().test_get_payment_uri()
+
+    @pytest.mark.skip(reason="TODO")
+    @override
+    def test_set_tx_note(self) -> None:
+        return super().test_set_tx_note()
+
+    @pytest.mark.skip(reason="TODO")
+    @override
+    def test_set_tx_notes(self):
+        return super().test_set_tx_notes()
+
+    @pytest.mark.skip(reason="TODO")
+    @override
+    def test_set_daemon_connection(self):
+        return super().test_set_daemon_connection()
+
+    @pytest.mark.skip(reason="TODO")
+    @override
+    def test_mining(self):
+        return super().test_mining()
+
+    @pytest.mark.skip(reason="TODO")
+    @override
+    def test_export_key_images(self):
+        return super().test_export_key_images()
+
+    @pytest.mark.skip(reason="TODO (monero-project): https://github.com/monero-project/monero/issues/5812")
+    @override
+    def test_import_key_images(self):
+        return super().test_import_key_images()
+
+    @pytest.mark.skip(reason="TODO")
+    @override
+    def test_get_new_key_images_from_last_import(self):
+        return super().test_get_new_key_images_from_last_import()
+
+    @pytest.mark.skip(reason="TODO")
+    @override
+    def test_subaddress_lookahead(self) -> None:
+        return super().test_subaddress_lookahead()
+
+    #endregion

tests/test_monero_wallet_keys.py

@@ -12,7 +12,6 @@
 from test_monero_wallet_common import BaseTestMoneroWallet
 
 logger: logging.Logger = logging.getLogger(__name__)
-Utils.load_config()
 
 
 class TestMoneroWalletKeys(BaseTestMoneroWallet):

tests/test_monero_wallet_rpc.py

@@ -5,8 +5,6 @@
 from utils import TestUtils as Utils
 from test_monero_wallet_common import BaseTestMoneroWallet
 
-Utils.load_config()
-
 
 class TestMoneroWalletRpc(BaseTestMoneroWallet):
 

tests/utils/test_utils.py

@@ -31,6 +31,9 @@ class TestUtils(ABC):
     __test__ = False
     _LOADED: bool = False
 
+    IN_CONTAINER: bool = False
+    """indicates if tests are running in docker container"""
+
     """directory with monero binaries to test (monerod and monero-wallet-rpc)"""
     WALLET_PORT_OFFSETS: dict[MoneroWalletRpc, int] = {}
 
@@ -71,7 +74,7 @@ class TestUtils(ABC):
     # test wallet constants
     MAX_FEE = 7500000*10000
     NETWORK_TYPE: MoneroNetworkType = MoneroNetworkType.MAINNET
-    REGTEST: bool = getenv("REGTEST") == "true" or True
+    REGTEST: bool = False
     LANGUAGE: str = ""
     SEED: str = ""
     ADDRESS: str = ""
@@ -104,12 +107,13 @@ def load_config(cls) -> None:
         assert parser.has_section("wallet")
 
         # parse general config
+        nettype_str = parser.get('general', 'network_type')
         cls.TEST_NON_RELAYS = parser.getboolean('general', 'test_non_relays')
         cls.TEST_NOTIFICATIONS = parser.getboolean('general', 'test_notifications')
         cls.LITE_MODE = parser.getboolean('general', 'lite_mode')
         cls.AUTO_CONNECT_TIMEOUT_MS = parser.getint('general', 'auto_connect_timeout_ms')
-        cls.NETWORK_TYPE = cls.parse_network_type(parser.get('general', 'network_type'))
-        cls._LOADED = True
+        cls.NETWORK_TYPE = cls.parse_network_type(nettype_str)
+        cls.REGTEST = cls.is_regtest(nettype_str)
 
         # parse daemon config
         cls.DAEMON_RPC_URI = parser.get('daemon', 'rpc_uri')
@@ -141,6 +145,9 @@ def load_config(cls) -> None:
         cls.WALLET_RPC_URI = cls.WALLET_RPC_DOMAIN + ":" + str(cls.WALLET_RPC_PORT_START)
         cls.WALLET_RPC_ZMQ_URI = "tcp:#" + cls.WALLET_RPC_ZMQ_DOMAIN + ":" + str(cls.WALLET_RPC_ZMQ_PORT_START)
         cls.SYNC_PERIOD_IN_MS = parser.getint('wallet', 'sync_period_in_ms')
+        in_container = getenv("IN_CONTAINER", "false")
+        cls.IN_CONTAINER = in_container.lower() == "true" or in_container == "1"
+        cls._LOADED = True
 
     @classmethod
     def current_timestamp(cls) -> int:
@@ -161,10 +168,17 @@ def network_type_to_str(cls, nettype: MoneroNetworkType) -> str:
 
         raise TypeError(f"Invalid network type provided: {str(nettype)}")
 
+    @classmethod
+    def is_regtest(cls, network_type_str: Optional[str]) -> bool:
+        if network_type_str is None:
+            return False
+        nettype = network_type_str.lower()
+        return nettype == "regtest" or nettype == "reg"
+
     @classmethod
     def parse_network_type(cls, nettype: str) -> MoneroNetworkType:
         net = nettype.lower()
-        if net == "mainnet" or net == "main":
+        if net == "mainnet" or net == "main" or cls.is_regtest(net):
             return MoneroNetworkType.MAINNET
         elif net == "testnet" or net == "test":
             return MoneroNetworkType.TESTNET
@@ -1031,3 +1045,6 @@ def test_get_blocks_range(
         for i, block in enumerate(blocks):
             cls.assert_equals(real_start_height + i, block.height)
             cls.test_block(block, block_ctx)
+
+
+TestUtils.load_config()