Skip to content

RFC: Update claude-code-review.yml to use centralized prompt #107

Description

@evansenter

Summary

Update the claude-code-review.yml GitHub Action workflows in all repositories to use the centralized review prompt hosted in dotfiles, ensuring consistent code review behavior across all codebases.

Problem / Motivation

The dotfiles repository hosts a sophisticated review prompt at home/.claude/contrib/prompts/claude-review.md with features including:

  • Structured severity levels (Critical/Important/Suggestion)
  • "Feedback Addressed" comment detection to avoid re-raising resolved issues
  • Linked issue checking for PR completeness validation
  • Clear verdict rules (REQUEST_CHANGES if any feedback, APPROVE only if perfect)
  • Prompt source attribution for traceability

Currently, some repositories still use inline prompts in their workflows, missing these improvements.

Context

Current Status

Repository Status
dotfiles ✅ Source of centralized prompt
gemicro ✅ Already uses centralized prompt
rust-genai ❌ Needs update
claude-event-bus ❌ Needs update
claude-session-analytics ❌ Needs update

Proposed Solution

Copy the workflow from dotfiles to each repository that needs updating. The workflow:

  1. Fetches the prompt from https://raw.githubusercontent.com/evansenter/dotfiles/main/home/.claude/contrib/prompts/claude-review.md
  2. Falls back to a basic inline prompt if fetch fails (with warning comment on PR)
  3. Uses the required tools for the prompt to function

Actionable Requirements

# Requirement Owner Blocked By
1 Update rust-genai workflow Claude None
2 Update claude-event-bus workflow Claude None
3 Update claude-session-analytics workflow Claude None
4 Verify workflows trigger correctly on next PR Human #1-3

Implementation Checklist

  • rust-genai: Replace .github/workflows/claude-code-review.yml
  • claude-event-bus: Replace .github/workflows/claude-code-review.yml
  • claude-session-analytics: Replace .github/workflows/claude-code-review.yml
  • Test by creating a small PR in each repo

Benefits

  • Single source of truth: Edit prompt once in dotfiles, all repos pick up changes
  • Consistent reviews: Same review criteria across all projects
  • Improved feedback loop: Feedback Addressed detection prevents redundant comments
  • Traceability: Prompt source link in each review comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    claude-codepriority:highUrgent, blocking other work, or critical bugrfcRequest for comments

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions