From fe763b097c8a76243be652e9629505239de69d3f Mon Sep 17 00:00:00 2001 From: Derek Xu Date: Tue, 23 Sep 2025 23:53:42 -0700 Subject: [PATCH] update once more --- name: Pull Request about: Propose changes to the codebase title: "Brief description of changes" labels: '' assignees: '' --- ## Description Please include a summary of the change and which issue is fixed or feature is implemented. Please also include relevant motivation and context. List any dependencies that are required for this change. Fixes # (issue) Implements # (issue) ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Refactoring/Code cleanup - [ ] Build/CI/CD related changes - [ ] Other (please describe): ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. - [ ] Test A - [ ] Test B **Test Configuration**: * Firmware version: * Hardware: * Toolchain: * SDK: ## Checklist: - [ ] My code follows the style guidelines of this project (ran `black .`, `isort .`, `flake8 .`) - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules - [ ] I have checked my code and corrected any misspellings ## Screenshots (if applicable) If applicable, add screenshots to help showcase your changes. ## Additional context Add any other context about the PR here. --- .github/workflows/e2e-smoke-test.yml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/e2e-smoke-test.yml b/.github/workflows/e2e-smoke-test.yml index 33876979..80541f33 100644 --- a/.github/workflows/e2e-smoke-test.yml +++ b/.github/workflows/e2e-smoke-test.yml @@ -189,16 +189,16 @@ jobs: echo " - Within acceptable range: 36%-60%" fi - - name: Send failure notification to Slack - uses: act10ns/slack@v1 - if: failure() - with: - status: failure - message: | - E2E Smoke Test failed - Success Rate: ${{ steps.run_test.outputs.success_rate || 'Unknown' }} - Expected: 36%-60% to pass - Test Exit Code: ${{ steps.run_test.outputs.test_exit_code || 'Unknown' }} - Job: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} - env: - SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} + # - name: Send failure notification to Slack + # uses: act10ns/slack@v1 + # if: failure() + # with: + # status: failure + # message: | + # E2E Smoke Test failed + # Success Rate: ${{ steps.run_test.outputs.success_rate || 'Unknown' }} + # Expected: 36%-60% to pass + # Test Exit Code: ${{ steps.run_test.outputs.test_exit_code || 'Unknown' }} + # Job: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} + # env: + # SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}