fix tests + add more

Author: Dylan Huang

eval_protocol/models.py

@@ -143,7 +143,12 @@ def rollout_finished(
             details.append(ErrorInfo.termination_reason(termination_reason).to_aip193_format())
         if extra_info:
             details.append(ErrorInfo.extra_info(extra_info).to_aip193_format())
-        return cls(code=cls.Code.FINISHED, message="Rollout finished", details=details)
+        return cls.finished("Rollout finished", details)
+
+    @classmethod
+    def finished(cls, message: str, details: Optional[List[Dict[str, Any]]] = None) -> "Status":
+        """Create a status indicating the rollout finished."""
+        return cls(code=cls.Code.FINISHED, message=message, details=details or [])
 
     @classmethod
     def rollout_error(cls, error_message: str, extra_info: Optional[Dict[str, Any]] = None) -> "Status":
@@ -156,7 +161,7 @@ def rollout_error(cls, error_message: str, extra_info: Optional[Dict[str, Any]]
     @classmethod
     def error(cls, error_message: str, details: Optional[List[Dict[str, Any]]] = None) -> "Status":
         """Create a status indicating the rollout failed with an error."""
-        return cls(code=cls.Code.INTERNAL, message=error_message, details=details)
+        return cls(code=cls.Code.INTERNAL, message=error_message, details=details or [])
 
     def is_running(self) -> bool:
         """Check if the status indicates the rollout is running."""

tests/test_logs_server.py

@@ -265,6 +265,7 @@ def test_should_update_status_not_running(self):
             eval_metadata=EvalMetadata(
                 name="test_eval", num_runs=1, aggregation_method="mean", status=Status.rollout_finished()
             ),
+            rollout_status=RolloutStatus.rollout_finished(),
             pid=12345,
         )
 

tests/test_status_model.py

@@ -345,6 +345,16 @@ def test_large_metadata(self):
         assert len(status.details) == 1
         assert status.details[0]["metadata"] == large_metadata
 
+    def test_empty_details_error(self):
+        """Test Status with empty details and error message."""
+        status = Status.error("Test error")
+        assert status.is_error()
+
+    def test_empty_details_error_finished(self):
+        """Test Status with empty details and error message."""
+        status = Status.finished("Test error")
+        assert status.is_finished()
+
 
 if __name__ == "__main__":
     pytest.main([__file__])