Skip to content

Commit f26eb1f

Browse files
committed
Merge branch 'derekx/redis-changes' of https://github.com/eval-protocol/python-sdk into derekx/redis-changes
2 parents 645c235 + aa85ed5 commit f26eb1f

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

eval_protocol/pytest/remote_rollout_processor.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def _default_output_data_loader(config: DataLoaderConfig) -> DynamicDataLoader:
5858
def fetch_traces() -> List[EvaluationRow]:
5959
base_url = config.model_base_url or "https://tracing.fireworks.ai"
6060
adapter = FireworksTracingAdapter(base_url=base_url)
61-
return adapter.get_evaluation_rows(tags=[f"rollout_id:{config.rollout_id}"], max_retries=5)
61+
return adapter.get_evaluation_rows(tags=[f"rollout_id:{config.rollout_id}"], proxy_max_retries=5)
6262

6363
return DynamicDataLoader(generators=[fetch_traces], preprocess_fn=filter_longest_conversation)
6464

@@ -188,7 +188,10 @@ async def _process_row(row: EvaluationRow) -> EvaluationRow:
188188
raise ValueError("Rollout ID is required in RemoteRolloutProcessor")
189189

190190
final_model_base_url = model_base_url
191-
if model_base_url and model_base_url.startswith("https://tracing.fireworks.ai"):
191+
if model_base_url and (
192+
model_base_url.startswith("https://tracing.fireworks.ai")
193+
or model_base_url.startswith("http://localhost")
194+
):
192195
final_model_base_url = _build_fireworks_tracing_url(model_base_url, meta)
193196

194197
init_payload: InitRequest = InitRequest(

tests/remote_server/test_remote_fireworks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def fetch_fireworks_traces(config: DataLoaderConfig) -> List[EvaluationRow]:
4343

4444
base_url = config.model_base_url or "https://tracing.fireworks.ai"
4545
adapter = FireworksTracingAdapter(base_url=base_url)
46-
return adapter.get_evaluation_rows(tags=[f"rollout_id:{config.rollout_id}"], max_retries=5)
46+
return adapter.get_evaluation_rows(tags=[f"rollout_id:{config.rollout_id}"], proxy_max_retries=5)
4747

4848

4949
def fireworks_output_data_loader(config: DataLoaderConfig) -> DynamicDataLoader:

0 commit comments

Comments
 (0)