Skip to content

Commit e7d638d

Browse files
committed
proper set to deprecated
1 parent 2aecc31 commit e7d638d

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

eval_protocol/models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -812,6 +812,7 @@ class ExecutionMetadata(BaseModel):
812812
# deprecated: use rollout_duration_seconds and eval_duration_seconds instead
813813
duration_seconds: Optional[float] = Field(
814814
default=None,
815+
deprecated=True,
815816
description="[Deprecated] Processing duration in seconds for this evaluation row. Note that if it gets retried, this will be the duration of the last attempt.",
816817
)
817818

eval_protocol/pytest/priority_scheduler.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -197,16 +197,13 @@ async def _run_eval(rows_to_eval: Union[EvaluationRow, List[EvaluationRow]]):
197197
if isinstance(eval_res, list):
198198
for row in eval_res:
199199
self.results.append(row)
200-
# Update eval progress bar (groupwise: 1 eval for the group)
201-
if self.eval_pbar:
202-
self.eval_pbar.update(1)
203200
else:
204201
self.results.append(eval_res)
205-
# Update eval progress bar (pointwise: 1 eval per row)
206-
if self.eval_pbar:
207-
self.eval_pbar.update(1)
208202
return eval_res
209203
finally:
204+
# Always update progress bar (handles both success and failure cases)
205+
if self.eval_pbar:
206+
self.eval_pbar.update(1)
210207
# Decrement active eval counter
211208
async with self.active_evals_lock:
212209
self.active_evals -= 1

0 commit comments

Comments
 (0)