fix test_parametrized_ids

Author: Dylan Huang

tests/pytest/test_parameterized_ids.py

@@ -91,47 +91,47 @@ def test_default_id_generator():
     generator = DefaultParameterIdGenerator()
 
     # Test with full model path
-    combo1 = (None, {"model": "fireworks_ai/accounts/fireworks/models/gpt-oss-120b"}, None, None, None)
+    combo1 = (None, {"model": "fireworks_ai/accounts/fireworks/models/gpt-oss-120b"}, None, None, None, None)
     id1 = generator.generate_id(combo1)
     assert id1 == "fireworks_ai/accounts/fireworks/models/gpt-oss-120b"
 
     # Test with simple model name
-    combo2 = (None, {"model": "gpt-4"}, None, None, None)
+    combo2 = (None, {"model": "gpt-4"}, None, None, None, None)
     id2 = generator.generate_id(combo2)
     assert id2 == "gpt-4"
 
     # Test with multiple string parameters
-    combo3 = (None, {"model": "gpt-4", "stream": "true", "temperature": "0.7"}, None, None, None)
+    combo3 = (None, {"model": "gpt-4", "stream": "true", "temperature": "0.7"}, None, None, None, None)
     id3 = generator.generate_id(combo3)
     assert id3 == "gpt-4:true:0.7"
 
     # Test with mixed string and numeric parameters
-    combo4 = (None, {"model": "gpt-4", "temperature": 0.7, "max_tokens": 100}, None, None, None)
+    combo4 = (None, {"model": "gpt-4", "temperature": 0.7, "max_tokens": 100}, None, None, None, None)
     id4 = generator.generate_id(combo4)
     assert id4 == "100:gpt-4:0.7"  # Keys are sorted alphabetically: max_tokens, model, temperature
 
     # Test with only numeric values
-    combo5 = (None, {"temperature": 0.5, "max_tokens": 100}, None, None, None)
+    combo5 = (None, {"temperature": 0.5, "max_tokens": 100}, None, None, None, None)
     id5 = generator.generate_id(combo5)
     assert id5 == "100:0.5"  # Keys are sorted alphabetically: max_tokens, temperature
 
     # Test with boolean values
-    combo6 = (None, {"stream": True, "echo": False}, None, None, None)
+    combo6 = (None, {"stream": True, "echo": False}, None, None, None, None)
     id6 = generator.generate_id(combo6)
     assert id6 == "False:True"  # Keys are sorted alphabetically: echo, stream
 
     # Test with mixed string, numeric, and boolean values
-    combo7 = (None, {"model": "gpt-4", "temperature": 0.7, "stream": True}, None, None, None)
+    combo7 = (None, {"model": "gpt-4", "temperature": 0.7, "stream": True}, None, None, None, None)
     id7 = generator.generate_id(combo7)
     assert id7 == "gpt-4:True:0.7"  # Keys are sorted alphabetically: model, stream, temperature
 
     # Test with no supported values (only non-supported types like lists, dicts)
-    combo8 = (None, {"messages": [{"role": "user"}], "config": {"key": "value"}}, None, None, None)
+    combo8 = (None, {"messages": [{"role": "user"}], "config": {"key": "value"}}, None, None, None, None)
     id8 = generator.generate_id(combo8)
     assert id8 is None
 
     # Test with None completion_params
-    combo9 = (None, None, None, None, None)
+    combo9 = (None, None, None, None, None, None)
     id9 = generator.generate_id(combo9)
     assert id9 is None
 
@@ -141,9 +141,9 @@ def test_pytest_parametrize_with_custom_id_generator():
 
     # Create test combinations
     combinations = [
-        (None, {"model": "gpt-4"}, None, None, None),
-        (None, {"model": "claude-3"}, None, None, None),
-        (None, {"temperature": 0.5}, None, None, None),  # Only numeric values
+        (None, {"model": "gpt-4"}, None, None, None, None),
+        (None, {"model": "claude-3"}, None, None, None, None),
+        (None, {"temperature": 0.5}, None, None, None, None),  # Only numeric values
     ]
 
     # Test with default generator
@@ -155,6 +155,7 @@ def test_pytest_parametrize_with_custom_id_generator():
         completion_params_provided=True,
         input_messages=None,
         input_rows=None,
+        data_loaders=None,
         evaluation_test_kwargs=None,
     )
 
@@ -168,7 +169,7 @@ def test_id_generator_max_length():
     generator = DefaultParameterIdGenerator(max_length=10)
 
     # Test with long model name
-    combo = (None, {"model": "very-long-model-name-that-exceeds-max-length"}, None, None, None)
+    combo = (None, {"model": "very-long-model-name-that-exceeds-max-length"}, None, None, None, None)
     id_str = generator.generate_id(combo)
     assert id_str == "very-lo..."
     assert len(id_str) <= 10