Skip to content

Commit d424168

Browse files
committed
fix test
1 parent 4a27a12 commit d424168

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

tests/pytest/test_utils.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import asyncio
2-
from unittest.mock import MagicMock
2+
from unittest.mock import AsyncMock, MagicMock
33
import pytest
44

55
from eval_protocol.pytest.evaluation_test_utils import rollout_processor_with_retry
@@ -16,6 +16,7 @@ def mock_rollout_processor(self):
1616
"""Create a mock rollout processor that returns async tasks."""
1717
processor = MagicMock()
1818
processor.cleanup = MagicMock()
19+
processor.aclose = AsyncMock() # async cleanup method
1920
return processor
2021

2122
@pytest.fixture
@@ -71,8 +72,8 @@ async def mock_task():
7172
assert mock_config.logger.log.call_count == 1
7273
mock_config.logger.log.assert_called_once_with(results[0])
7374

74-
# Verify cleanup was called
75-
mock_rollout_processor.cleanup.assert_called_once()
75+
# Verify async cleanup was called (aclose is preferred over cleanup)
76+
mock_rollout_processor.aclose.assert_awaited_once()
7677

7778
@pytest.mark.asyncio
7879
async def test_logger_called_on_failed_execution(self, mock_rollout_processor, mock_config, sample_dataset):
@@ -97,8 +98,8 @@ async def failing_task():
9798
assert results[0].rollout_status.code == 13 # INTERNAL error code
9899
assert "Test error" in results[0].rollout_status.message
99100

100-
# Verify cleanup was called
101-
mock_rollout_processor.cleanup.assert_called_once()
101+
# Verify async cleanup was called (aclose is preferred over cleanup)
102+
mock_rollout_processor.aclose.assert_awaited_once()
102103

103104
@pytest.mark.asyncio
104105
async def test_logger_called_on_retry_execution(self, mock_rollout_processor, mock_config, sample_dataset):
@@ -134,8 +135,8 @@ async def flaky_task():
134135
assert mock_config.logger.log.call_count == 1
135136
mock_config.logger.log.assert_called_once_with(results[0])
136137

137-
# Verify cleanup was called
138-
mock_rollout_processor.cleanup.assert_called_once()
138+
# Verify async cleanup was called (aclose is preferred over cleanup)
139+
mock_rollout_processor.aclose.assert_awaited_once()
139140

140141
@pytest.mark.asyncio
141142
async def test_logger_called_for_multiple_rows(self, mock_rollout_processor, mock_config):
@@ -182,8 +183,8 @@ async def mock_task():
182183
assert mock_config.logger.log.call_count == 2
183184
assert len(results) == 2
184185

185-
# Verify cleanup was called
186-
mock_rollout_processor.cleanup.assert_called_once()
186+
# Verify async cleanup was called (aclose is preferred over cleanup)
187+
mock_rollout_processor.aclose.assert_awaited_once()
187188

188189
@pytest.mark.asyncio
189190
async def test_logger_called_even_when_processor_fails_to_initialize(

0 commit comments

Comments
 (0)