fix per comment

Author: benjibc

eval_protocol/pytest/default_langchain_rollout_processor.py

@@ -21,9 +21,8 @@ class LangGraphRolloutProcessor(RolloutProcessor):
     def __init__(
         self,
         *,
-        # Prefer factory that accepts RolloutProcessorConfig for parity with Pydantic pattern.
-        # For backward compatibility, factories accepting a Dict[str, Any] (graph kwargs) are still supported.
-        graph_factory: Callable[[Any], Any],
+        # Factory must accept RolloutProcessorConfig (parity with Pydantic AI processor)
+        graph_factory: Callable[[RolloutProcessorConfig], Any],
         to_input: Optional[Callable[[EvaluationRow], Dict[str, Any]]] = None,
         apply_result: Optional[Callable[[EvaluationRow, Any], EvaluationRow]] = None,
         build_graph_kwargs: Optional[Callable[[CompletionParams], Dict[str, Any]]] = None,
@@ -126,12 +125,8 @@ def __call__(self, rows: List[EvaluationRow], config: RolloutProcessorConfig) ->
         if config.completion_params:
             graph_config = build_kwargs(config.completion_params)
 
-        # (Re)build the graph for this call. Prefer passing full config to factory;
-        # fall back to old dict-based factories if needed.
-        try:
-            graph_target = self._graph_factory(config)  # type: ignore[arg-type]
-        except TypeError:
-            graph_target = self._graph_factory(graph_config or {})
+        # (Re)build the graph for this call using the full typed config.
+        graph_target = self._graph_factory(config)
 
         # Build per-invoke config if provided; otherwise reuse graph_config for backwards compat
         invoke_config: Optional[Dict[str, Any]] = None

examples/langgraph/__init__.py

@@ -1,2 +1 @@
 # Package marker for examples.langgraph
-

tests/pytest/test_langgraph_processor.py

@@ -7,6 +7,7 @@
 
 from eval_protocol.models import EvaluationRow, Message
 from eval_protocol.pytest.default_langchain_rollout_processor import LangGraphRolloutProcessor
+from eval_protocol.pytest.types import RolloutProcessorConfig
 
 
 class DummyLCMessage:
@@ -25,7 +26,7 @@ async def ainvoke(self, payload: Dict[str, Any], **_: Any):
 
 
 def _make_processor_with_defaults(out_messages: List[Any]) -> LangGraphRolloutProcessor:
-    def graph_factory(_: Dict[str, Any]):
+    def graph_factory(_: RolloutProcessorConfig):
         return DummyGraph(out_messages)
 
     return LangGraphRolloutProcessor(graph_factory=graph_factory)
@@ -116,7 +117,7 @@ async def ainvoke(self, payload, **_):
             # Ensure our adapter-produced messages flow through
             return payload
 
-    processor = LangGraphRolloutProcessor(graph_factory=lambda _: EchoGraph())
+    processor = LangGraphRolloutProcessor(graph_factory=lambda _config: EchoGraph())
 
     # Act
     tasks = processor(