Skip to content

Commit beae947

Browse files
author
Dylan Huang
committed
fix tests
1 parent 8e54f84 commit beae947

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

eval_protocol/utils/logs_server.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,6 @@ def broadcast_row_upserted(self, row: "EvaluationRow"):
9595
active_connections_count = len(self.active_connections)
9696
logger.debug(f"[WEBSOCKET_BROADCAST] Active connections: {active_connections_count}")
9797

98-
if active_connections_count == 0:
99-
logger.debug(
100-
f"[WEBSOCKET_BROADCAST] No active connections, skipping broadcast for rollout_id: {rollout_id}"
101-
)
102-
return
103-
10498
try:
10599
# Serialize pydantic model
106100
logger.debug(f"[WEBSOCKET_BROADCAST] Serializing row for rollout_id: {rollout_id}")

tests/test_logs_server.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ def test_serve_logs_port_parameter(self, temp_build_dir):
373373
serve_logs(port=test_port)
374374

375375
# Verify that LogsServer was created with the correct port
376-
mock_logs_server_class.assert_called_once_with(port=test_port, elasticsearch_config=None)
376+
mock_logs_server_class.assert_called_once_with(port=test_port, elasticsearch_config=None, debug=False)
377377
# Verify that the run method was called on the instance
378378
mock_server_instance.run.assert_called_once()
379379

@@ -387,7 +387,7 @@ def test_serve_logs_default_port(self, temp_build_dir):
387387
serve_logs()
388388

389389
# Verify that LogsServer was created with None port (which will use LogsServer's default of 8000)
390-
mock_logs_server_class.assert_called_once_with(port=None, elasticsearch_config=None)
390+
mock_logs_server_class.assert_called_once_with(port=None, elasticsearch_config=None, debug=False)
391391
# Verify that the run method was called on the instance
392392
mock_server_instance.run.assert_called_once()
393393

0 commit comments

Comments
 (0)