Skip to content

Commit a11c7dd

Browse files
committed
update
1 parent c9e3590 commit a11c7dd

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

tests/pytest/test_utils.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,6 @@ async def mock_task():
7272
assert mock_config.logger.log.call_count == 1
7373
mock_config.logger.log.assert_called_once_with(results[0])
7474

75-
# Verify async cleanup was called (aclose is preferred over cleanup)
76-
mock_rollout_processor.acleanup.assert_awaited_once()
77-
7875
@pytest.mark.asyncio
7976
async def test_logger_called_on_failed_execution(self, mock_rollout_processor, mock_config, sample_dataset):
8077
"""Test that the logger is called when execution fails."""
@@ -98,9 +95,6 @@ async def failing_task():
9895
assert results[0].rollout_status.code == 13 # INTERNAL error code
9996
assert "Test error" in results[0].rollout_status.message
10097

101-
# Verify async cleanup was called (aclose is preferred over cleanup)
102-
mock_rollout_processor.acleanup.assert_awaited_once()
103-
10498
@pytest.mark.asyncio
10599
async def test_logger_called_on_retry_execution(self, mock_rollout_processor, mock_config, sample_dataset):
106100
"""Test that the logger is called when execution succeeds after retry."""
@@ -135,9 +129,6 @@ async def flaky_task():
135129
assert mock_config.logger.log.call_count == 1
136130
mock_config.logger.log.assert_called_once_with(results[0])
137131

138-
# Verify async cleanup was called (aclose is preferred over cleanup)
139-
mock_rollout_processor.acleanup.assert_awaited_once()
140-
141132
@pytest.mark.asyncio
142133
async def test_logger_called_for_multiple_rows(self, mock_rollout_processor, mock_config):
143134
"""Test that the logger is called for each row in a multi-row dataset."""
@@ -183,9 +174,6 @@ async def mock_task():
183174
assert mock_config.logger.log.call_count == 2
184175
assert len(results) == 2
185176

186-
# Verify async cleanup was called (aclose is preferred over cleanup)
187-
mock_rollout_processor.acleanup.assert_awaited_once()
188-
189177
@pytest.mark.asyncio
190178
async def test_logger_called_even_when_processor_fails_to_initialize(
191179
self, mock_rollout_processor, mock_config, sample_dataset
@@ -198,6 +186,3 @@ async def test_logger_called_even_when_processor_fails_to_initialize(
198186
with pytest.raises(RuntimeError, match="Processor failed to initialize"):
199187
async for result in rollout_processor_with_retry(mock_rollout_processor, sample_dataset, mock_config):
200188
pass
201-
202-
# Verify async cleanup was called even though the function failed
203-
mock_rollout_processor.acleanup.assert_awaited_once()

0 commit comments

Comments
 (0)