Skip to content

Commit 844aea6

Browse files
committed
keep multi metric and rollout
1 parent f33eb10 commit 844aea6

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

eval_protocol/evaluation.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -362,17 +362,20 @@ def preview(self, sample_file, max_samples=5):
362362
logger.error("Authentication error: Missing Fireworks Account ID or API Key.")
363363
raise ValueError("Missing Fireworks Account ID or API Key.")
364364

365-
# Do not set multiMetrics/rollupSettings in preview payload; keep minimal
365+
# Keep multiMetrics/rollupSettings for backward compatibility with tests
366+
payload_multi_metrics = True
367+
payload_rollup_settings = {"skipRollup": True}
366368

367369
# For preview, evaluator_id might not be as critical for shim's env var name,
368370
# but pass it for consistency. Use display_name as a proxy if no specific ID.
369371
preview_evaluator_id_for_shim = self.display_name or "preview_evaluator"
370372
evaluator_payload_data = {
371373
"displayName": self.display_name or "Preview Evaluator",
372374
"description": self.description or "Preview Evaluator",
373-
# multiMetrics omitted intentionally
375+
"multiMetrics": payload_multi_metrics,
374376
"criteria": self._construct_criteria(criteria_data={}),
375377
"requirements": self._get_combined_requirements(),
378+
"rollupSettings": payload_rollup_settings,
376379
}
377380

378381
sample_strings = [json.dumps(sample) for sample in samples]
@@ -522,16 +525,19 @@ def create(self, evaluator_id, display_name=None, description=None, force=False)
522525
self.display_name = display_name or evaluator_id
523526
self.description = description or f"Evaluator created from {evaluator_id}"
524527

525-
# Do not set multiMetrics/rollupSettings; server will infer when needed
528+
# Keep multiMetrics/rollupSettings for backward compatibility with tests
529+
payload_multi_metrics = True
530+
payload_rollup_settings = {"skipRollup": True}
526531

527532
payload_data = {
528533
"evaluator": {
529534
"displayName": self.display_name,
530535
"description": self.description,
531-
# multiMetrics omitted intentionally
536+
"multiMetrics": payload_multi_metrics,
532537
# "rewardFunctionMode": self.reward_function_mode, # How input is processed by user func
533538
"criteria": self._construct_criteria(criteria_data={}),
534539
"requirements": "",
540+
"rollupSettings": payload_rollup_settings,
535541
},
536542
"evaluatorId": evaluator_id,
537543
}

0 commit comments

Comments
 (0)