Skip to content

Commit 76cc1e7

Browse files
author
Dylan Huang
authored
Make messages optional on InitRequest (#228)
* Make messages optional on InitRequest * handle optional messages * update version
1 parent 626a125 commit 76cc1e7

File tree

5 files changed

+108
-3
lines changed

5 files changed

+108
-3
lines changed

eval_protocol/types/remote_rollout_processor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class InitRequest(BaseModel):
2121
"""Request model for POST /init endpoint."""
2222

2323
model: str
24-
messages: List[Message] = Field(min_length=1)
24+
messages: Optional[List[Message]] = None
2525
tools: Optional[List[Dict[str, Any]]] = None
2626

2727
model_base_url: Optional[str] = None

tests/remote_server/remote_server.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ def _worker():
3030
try:
3131
metadata = {"langfuse_tags": create_langfuse_config_tags(req)}
3232

33+
if not req.messages:
34+
raise ValueError("messages is required")
35+
3336
completion_kwargs = {
3437
"model": req.model,
3538
"messages": req.messages,

typescript/index.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const metadataSchema = z
4141

4242
export const initRequestSchema = z.object({
4343
model: z.string(),
44-
messages: z.array(messageSchema).min(1),
44+
messages: z.array(messageSchema).optional(),
4545
tools: z.array(toolSchema).optional().nullable(),
4646
metadata: metadataSchema,
4747
model_base_url: z.string().optional().nullable(),
@@ -80,6 +80,10 @@ export function initRequestToCompletionParams(
8080
},
8181
}));
8282

83+
if (!initRequest.messages) {
84+
throw new Error("messages is required");
85+
}
86+
8387
const completionParams = toolsToOpenAI
8488
? {
8589
model: initRequest.model,

typescript/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "eval-protocol",
33
"module": "index.ts",
44
"type": "module",
5-
"version": "0.1.3",
5+
"version": "0.1.4",
66
"devDependencies": {
77
"@types/bun": "latest",
88
"openai": "^5.23.0"

typescript/pnpm-lock.yaml

Lines changed: 98 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)