Skip to content

Commit 71ddf9b

Browse files
author
Dylan Huang
authored
rename param for RemoteRolloutProcessor (#270)
* rename * update ElasticsearchConfig
1 parent 747a88a commit 71ddf9b

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

eval_protocol/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
from .log_utils.rollout_id_filter import RolloutIdFilter
3737
from .log_utils.util import setup_rollout_logging_for_elasticsearch_handler
3838
from .log_utils.fireworks_tracing_http_handler import FireworksTracingHttpHandler
39+
from .log_utils.elasticsearch_client import ElasticsearchConfig
3940

4041

4142
from .types.remote_rollout_processor import (
@@ -75,6 +76,7 @@
7576
warnings.filterwarnings("default", category=DeprecationWarning, module="eval_protocol")
7677

7778
__all__ = [
79+
"ElasticsearchConfig",
7880
"ElasticsearchDirectHttpHandler",
7981
"RolloutIdFilter",
8082
"setup_rollout_logging_for_elasticsearch_handler",

eval_protocol/pytest/remote_rollout_processor.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def __init__(
9393
poll_interval: float = 1.0,
9494
timeout_seconds: float = 120.0,
9595
output_data_loader: Optional[Callable[[DataLoaderConfig], DynamicDataLoader]] = None,
96-
disable_elastic_search: bool = False,
96+
disable_elastic_search_setup: bool = False,
9797
elastic_search_config: Optional[ElasticsearchConfig] = None,
9898
):
9999
# Prefer constructor-provided configuration. These can be overridden via
@@ -108,11 +108,11 @@ def __init__(
108108
self._poll_interval = poll_interval
109109
self._timeout_seconds = timeout_seconds
110110
self._output_data_loader = output_data_loader or _default_output_data_loader
111-
self._disable_elastic_search = disable_elastic_search
111+
self._disable_elastic_search_setup = disable_elastic_search_setup
112112
self._elastic_search_config = elastic_search_config
113113

114114
def setup(self) -> None:
115-
if self._disable_elastic_search:
115+
if self._disable_elastic_search_setup:
116116
logger.info("Elasticsearch is disabled, skipping setup")
117117
return
118118
logger.info("Setting up Elasticsearch")

0 commit comments

Comments
 (0)