Skip to content

Commit 5dca8be

Browse files
authored
Revert "add try catch (#297)"
This reverts commit aa1bc9f.
1 parent 231640b commit 5dca8be

File tree

1 file changed

+10
-28
lines changed

1 file changed

+10
-28
lines changed

eval_protocol/pytest/evaluation_test.py

Lines changed: 10 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
EvaluationRow,
2020
EvaluationThreshold,
2121
EvaluationThresholdDict,
22-
EvaluateResult,
2322
Status,
2423
)
2524
from eval_protocol.pytest.dual_mode_wrapper import create_dual_mode_wrapper
@@ -430,19 +429,11 @@ async def _execute_pointwise_eval_with_semaphore(
430429
experiment_id=experiment_id,
431430
run_id=run_id,
432431
):
433-
try:
434-
result = await execute_pytest(
435-
test_func,
436-
processed_row=row,
437-
evaluation_test_kwargs=evaluation_test_kwargs,
438-
)
439-
except Exception as e:
440-
result = row
441-
result.evaluation_result = EvaluateResult(
442-
score=0.0,
443-
is_score_valid=False,
444-
reason=f"Error during evaluation: {type(e).__name__}: {e}",
445-
)
432+
result = await execute_pytest(
433+
test_func,
434+
processed_row=row,
435+
evaluation_test_kwargs=evaluation_test_kwargs,
436+
)
446437
if not isinstance(result, EvaluationRow):
447438
raise ValueError(
448439
f"Test function {test_func.__name__} did not return an EvaluationRow instance. You must return an EvaluationRow instance from your test function decorated with @evaluation_test."
@@ -464,20 +455,11 @@ async def _execute_groupwise_eval_with_semaphore(
464455
run_id=run_id,
465456
rollout_ids=group_rollout_ids or None,
466457
):
467-
try:
468-
results = await execute_pytest(
469-
test_func,
470-
processed_dataset=rows,
471-
evaluation_test_kwargs=evaluation_test_kwargs,
472-
)
473-
except Exception as e:
474-
results = rows
475-
for row in results:
476-
row.evaluation_result = EvaluateResult(
477-
score=0.0,
478-
is_score_valid=False,
479-
reason=f"Error during evaluation: {type(e).__name__}: {e}",
480-
)
458+
results = await execute_pytest(
459+
test_func,
460+
processed_dataset=rows,
461+
evaluation_test_kwargs=evaluation_test_kwargs,
462+
)
481463
if not isinstance(results, list):
482464
raise ValueError(
483465
f"Test function {test_func.__name__} did not return a list of EvaluationRow instances. You must return a list of EvaluationRow instances from your test function decorated with @evaluation_test."

0 commit comments

Comments
 (0)