Skip to content

Commit 03d3b0c

Browse files
committed
use get
1 parent 260f721 commit 03d3b0c

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

eval_protocol/adapters/fireworks_tracing.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -321,8 +321,8 @@ def get_evaluation_rows(
321321

322322
eval_rows = []
323323

324-
# Build request payload
325-
payload = {
324+
# Build query parameters for GET request
325+
params = {
326326
"limit": limit,
327327
"sample_size": sample_size,
328328
"tags": tags,
@@ -336,14 +336,12 @@ def get_evaluation_rows(
336336
"hours_back": hours_back,
337337
"from_timestamp": from_timestamp.isoformat() if from_timestamp else None,
338338
"to_timestamp": to_timestamp.isoformat() if to_timestamp else None,
339-
"include_tool_calls": include_tool_calls,
340339
"sleep_between_gets": sleep_between_gets,
341340
"max_retries": max_retries,
342-
"span_name": span_name,
343341
}
344342

345343
# Remove None values
346-
payload = {k: v for k, v in payload.items() if v is not None}
344+
params = {k: v for k, v in params.items() if v is not None}
347345

348346
# Make request to proxy
349347
if self.project_id:
@@ -352,7 +350,7 @@ def get_evaluation_rows(
352350
url = f"{self.base_url}/v1/traces"
353351

354352
try:
355-
response = requests.post(url, json=payload, timeout=self.timeout)
353+
response = requests.get(url, params=params, timeout=self.timeout)
356354
response.raise_for_status()
357355
result = response.json()
358356
except requests.exceptions.RequestException as e:

0 commit comments

Comments
 (0)