Skip to content

Commit ec8888a

Browse files
authored
docs: align dev image name, avoid :dev tag (#16)
we have added tip to use it, and to force image cache clear with: https://eval-hub.github.io/development/openshift-setup/#removing-cached-images-from-nodes however I'd say if someone is developing locally, :latest is more appropriate for dev cycles Signed-off-by: tarilabs <matteo.mortari@gmail.com>
1 parent 098fc56 commit ec8888a

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

docs/development/openshift-setup.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -453,12 +453,13 @@ Build a custom EvalHub server image:
453453

454454
```bash
455455
cd eval-hub
456+
IMG=quay.io/your-org/evalhub
456457

457458
# Build with Podman
458-
podman build --platform linux/amd64 -t quay.io/your-org/eval-hub:dev .
459+
podman build --platform linux/amd64 -t $IMG .
459460

460461
# Push to registry
461-
podman push quay.io/your-org/eval-hub:dev
462+
podman push $IMG
462463
```
463464

464465
Update the operator manifests to use your custom image:
@@ -469,7 +470,7 @@ cd trustyai-service-operator
469470
vim config/overlays/odh/params.env
470471

471472
# Change evalHubImage to your custom image
472-
# evalHubImage=quay.io/your-org/eval-hub:dev
473+
# evalHubImage=quay.io/your-org/evalhub:latest
473474
```
474475

475476
Then upload the modified manifests using the commands from the previous section:
@@ -764,7 +765,7 @@ When using a tag other than `latest`, Kubernetes defaults (if no otherwise speci
764765
**Remove a cached image from all worker nodes:**
765766

766767
```bash
767-
IMG=quay.io/your-org/eval-hub:dev
768+
IMG=quay.io/your-org/evalhub:dev
768769
oc get nodes -l node-role.kubernetes.io/worker -o jsonpath='{range .items[*]}{.metadata.name}{"\n"}{end}' | while read NODE; do
769770
oc debug node/$NODE --quiet -- chroot /host crictl rmi $IMG
770771
done

0 commit comments

Comments
 (0)