Skip to content

Commit 1a75068

Browse files
committed
chore(Php): Add ci tests for PHP 8.0 to 8.4
[bump-react-promise-support]
1 parent e6a9a19 commit 1a75068

5 files changed

Lines changed: 8 additions & 5 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- 8080:80
1212
strategy:
1313
matrix:
14-
php-versions: [ '8.0', '8.1' ]
14+
php-versions: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]
1515
composer-options: [ '--prefer-lowest', '']
1616
runs-on: ubuntu-latest
1717
steps:

Curl/CurlErrorException.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@
99

1010
namespace evaisse\SimpleHttpBundle\Curl;
1111

12+
use Exception;
13+
1214
class CurlErrorException extends \RuntimeException
1315
{
14-
public function __construct($message="", $code=0, \Exception $previous=null) {
16+
public function __construct($message="", $code=0, ?Exception $previous=null) {
1517
parent::__construct($message,$code,$previous);
1618
}
1719
}

Curl/MultiManager.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ class MultiManager implements CurlRequest
5757
* @param boolean $blocking Whether the execution should block until finished or wait until
5858
* the destructor is called to block
5959
*/
60-
public function __construct(EventDispatcherInterface $dispatcher=null,$blocking=true) {
60+
public function __construct(?EventDispatcherInterface $dispatcher = null, $blocking = true)
61+
{
6162
$this->dispatcher = $dispatcher;
6263
$this->handle = curl_multi_init();
6364
$this->blocking = $blocking;

Http/Exception/RequestException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class RequestException extends Exception
2626
* @param int $code error code
2727
* @param Exception $previous optionnal previous exception
2828
*/
29-
public function __construct(Request $request, $message = "", $code = 0, Exception $previous = null)
29+
public function __construct(Request $request, $message = "", $code = 0, ?Exception $previous = null)
3030
{
3131
parent::__construct($message, $code, $previous); // TODO: Change the autogenerated stub
3232
$this->setRequest($request);

Service/Helper.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function createCookieJar(?SessionInterface $session = null): SessionCooki
5858
* @param Kernel|null $client http client proxy to use
5959
* @return Helper given service list
6060
*/
61-
public function execute(array $servicesList, ?SessionCookieJar $cookieJar = null, Kernel $client = null): static
61+
public function execute(array $servicesList, ?SessionCookieJar $cookieJar = null, ?Kernel $client = null): static
6262
{
6363
$httpClient = $client ? $client : $this->httpKernel;
6464

0 commit comments

Comments
 (0)