Skip to content

Commit b7d9138

Browse files
etrclaude
andcommitted
TASK-011: housekeeping (status + checkboxes + review records)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 0d0ea3d commit b7d9138

4 files changed

Lines changed: 137 additions & 9 deletions

File tree

specs/tasks/M2-response/TASK-011.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@
88
Make read accessors callable on `const http_response&`, returning views without inserting on miss.
99

1010
**Action Items:**
11-
- [ ] `std::string_view get_header(std::string_view key) const;` returns empty view on miss; does NOT insert.
12-
- [ ] Same for `get_footer(std::string_view) const;` and `get_cookie(std::string_view) const;`.
13-
- [ ] `const header_map& get_headers() const noexcept;` (and `get_footers`, `get_cookies`).
14-
- [ ] `int get_status() const noexcept;`
15-
- [ ] `body_kind kind() const noexcept;`
16-
- [ ] Remove any v1 accessor that inserted on miss (e.g., `headers[key]` patterns).
17-
- [ ] Audit `string_view` returns: the storage must outlive the view. Document lifetime contract on each accessor (views invalidated by mutation of the response, e.g., `with_header` may rehash the map).
11+
- [x] `std::string_view get_header(std::string_view key) const;` returns empty view on miss; does NOT insert.
12+
- [x] Same for `get_footer(std::string_view) const;` and `get_cookie(std::string_view) const;`.
13+
- [x] `const header_map& get_headers() const noexcept;` (and `get_footers`, `get_cookies`).
14+
- [x] `int get_status() const noexcept;`
15+
- [x] `body_kind kind() const noexcept;`
16+
- [x] Remove any v1 accessor that inserted on miss (e.g., `headers[key]` patterns).
17+
- [x] Audit `string_view` returns: the storage must outlive the view. Document lifetime contract on each accessor (views invalidated by mutation of the response, e.g., `with_header` may rehash the map).
1818

1919
**Dependencies:**
2020
- Blocked by: TASK-009
@@ -30,4 +30,4 @@ Make read accessors callable on `const http_response&`, returning views without
3030
**Related Requirements:** PRD-RSP-REQ-002, PRD-RSP-REQ-003
3131
**Related Decisions:** §2.2 (const correctness), §4.3
3232

33-
**Status:** Not Started
33+
**Status:** Done

specs/tasks/_index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ Nominally: **13 sequential tasks**, each S–XL. Most other tasks parallelize of
9393
| TASK-008 | Internal `detail::body` hierarchy | M2 | Done | TASK-002 |
9494
| TASK-009 | `http_response` value type with SBO buffer | M2 | Done | TASK-008 |
9595
| TASK-010 | `http_response` factory functions | M2 | Done | TASK-008, TASK-009, TASK-004 |
96-
| TASK-011 | `http_response` const-correct accessors | M2 | Not Started | TASK-009 |
96+
| TASK-011 | `http_response` const-correct accessors | M2 | Done | TASK-009 |
9797
| TASK-012 | `http_response` fluent `with_*` setters | M2 | Not Started | TASK-009 |
9898
| TASK-013 | Remove `*_response` subclasses and dispatch virtuals | M2 | Not Started | TASK-009, TASK-010, TASK-011, TASK-012 |
9999
| TASK-014 | `webserver_impl` skeleton (PIMPL prep) | M3 | Not Started | TASK-002 |
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# Unworked Review Issues
2+
3+
**Run:** 2026-05-03 21:10:00
4+
**Task:** TASK-011
5+
**Total:** 0 (0 critical, 0 major, 0 minor)
6+
7+
No unworked findings. All critical and major findings (task status Not Started → Done, seven action-item checkboxes) were resolved in the housekeeping pass.

0 commit comments

Comments
 (0)