TASK-009: review-pass fixes (code-quality iter2: details→detail namespace)

Rename `httpserver::details` namespace → `httpserver::detail` across all
remaining source/test files so the namespace name matches the renamed
directory (per TASK-009 directory rename `src/{,httpserver/}details/` →
`src/{,httpserver/}detail/`). Carried-over headers and CPPs that still
qualified internal types as `httpserver::details::X` would otherwise
fail to compile with the now-canonical `httpserver::detail` declarations.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: etr

src/deferred_response.cpp

@@ -26,12 +26,12 @@ struct MHD_Response;
 
 namespace httpserver {
 
-namespace details {
+namespace detail {
 
 MHD_Response* get_raw_response_helper(void* cls, ssize_t (*cb)(void*, uint64_t, char*, size_t)) {
     return MHD_create_response_from_callback(MHD_SIZE_UNKNOWN, 1024, cb, cls, nullptr);
 }
 
-}  // namespace details
+}  // namespace detail
 
 }  // namespace httpserver

src/detail/http_endpoint.cpp

@@ -37,7 +37,7 @@ using std::vector;
 
 namespace httpserver {
 
-namespace details {
+namespace detail {
 
 http_endpoint::~http_endpoint() {
 }
@@ -162,6 +162,6 @@ bool http_endpoint::match(const http_endpoint& url) const {
     return regex_match(nn, re_url_normalized);
 }
 
-}  // namespace details
+}  // namespace detail
 
 }  // namespace httpserver

src/http_resource.cpp

@@ -43,12 +43,12 @@ void resource_init(std::map<std::string, bool>* method_state) {
     (*method_state)[MHD_HTTP_METHOD_PATCH] = true;
 }
 
-namespace details {
+namespace detail {
 
 std::shared_ptr<http_response> empty_render(const http_request&) {
     return std::make_shared<string_response>();
 }
 
-}  // namespace details
+}  // namespace detail
 
 }  // namespace httpserver

src/httpserver/deferred_response.hpp

@@ -39,9 +39,9 @@ struct MHD_Response;
 
 namespace httpserver {
 
-namespace details {
+namespace detail {
 MHD_Response* get_raw_response_helper(void* cls, ssize_t (*cb)(void*, uint64_t, char*, size_t));
-}  // namespace details
+}  // namespace detail
 
 template <class T>
 class deferred_response : public string_response {
@@ -67,7 +67,7 @@ class deferred_response : public string_response {
      ~deferred_response() = default;
 
      MHD_Response* get_raw_response() {
-         return details::get_raw_response_helper(reinterpret_cast<void*>(this), &cb);
+         return detail::get_raw_response_helper(reinterpret_cast<void*>(this), &cb);
      }
 
  private:

src/httpserver/detail/http_endpoint.hpp

@@ -35,7 +35,7 @@
 
 namespace httpserver {
 
-namespace details {
+namespace detail {
 
 class http_resource;
 
@@ -190,7 +190,7 @@ class http_endpoint {
      bool reg_compiled;
 };
 
-}  // namespace details
+}  // namespace detail
 
 }  // namespace httpserver
 #endif  // SRC_HTTPSERVER_DETAIL_HTTP_ENDPOINT_HPP_

src/httpserver/detail/modded_request.hpp

@@ -33,7 +33,7 @@
 
 namespace httpserver {
 
-namespace details {
+namespace detail {
 
 struct modded_request {
     struct MHD_PostProcessor *pp = nullptr;
@@ -66,7 +66,7 @@ struct modded_request {
     }
 };
 
-}  // namespace details
+}  // namespace detail
 
 }  // namespace httpserver
 

src/httpserver/http_request.hpp

@@ -52,7 +52,7 @@ struct MHD_Connection;
 
 namespace httpserver {
 
-namespace details { struct modded_request; }
+namespace detail { struct modded_request; }
 
 /**
  * Class representing an abstraction for an Http Request. It is used from classes using these apis to receive information through http protocol.
@@ -534,7 +534,7 @@ class http_request {
      }
 
      friend class webserver;
-     friend struct details::modded_request;
+     friend struct detail::modded_request;
 };
 
 std::ostream &operator<< (std::ostream &os, const http_request &r);

src/httpserver/http_resource.hpp

@@ -40,7 +40,7 @@ namespace httpserver { class http_response; }
 
 namespace httpserver {
 
-namespace details { std::shared_ptr<http_response> empty_render(const http_request& r); }
+namespace detail { std::shared_ptr<http_response> empty_render(const http_request& r); }
 
 void resource_init(std::map<std::string, bool>* res);
 
@@ -60,7 +60,7 @@ class http_resource {
       * @return A http_response object
      **/
      virtual std::shared_ptr<http_response> render(const http_request& req) {
-         return details::empty_render(req);
+         return detail::empty_render(req);
      }
 
      /**

src/httpserver/webserver.hpp

@@ -59,7 +59,7 @@ namespace httpserver { class http_response; }
 #ifdef HAVE_WEBSOCKET
 namespace httpserver { class websocket_handler; }
 #endif  // HAVE_WEBSOCKET
-namespace httpserver { namespace details { struct modded_request; } }
+namespace httpserver { namespace detail { struct modded_request; } }
 
 struct MHD_Connection;
 
@@ -277,12 +277,12 @@ class webserver {
      const bool no_alpn;
      const int client_discipline_level;
      std::shared_mutex registered_resources_mutex;
-     std::map<details::http_endpoint, http_resource*> registered_resources;
+     std::map<detail::http_endpoint, http_resource*> registered_resources;
      std::map<std::string, http_resource*> registered_resources_str;
-     std::map<details::http_endpoint, http_resource*> registered_resources_regex;
+     std::map<detail::http_endpoint, http_resource*> registered_resources_regex;
 
      struct route_cache_entry {
-         details::http_endpoint matched_endpoint;
+         detail::http_endpoint matched_endpoint;
          http_resource* resource;
      };
      static constexpr size_t ROUTE_CACHE_MAX_SIZE = 256;
@@ -302,9 +302,9 @@ class webserver {
      std::map<std::string, websocket_handler*> registered_ws_handlers;
 #endif  // HAVE_WEBSOCKET
 
-     std::shared_ptr<http_response> method_not_allowed_page(details::modded_request* mr) const;
-     std::shared_ptr<http_response> internal_error_page(details::modded_request* mr, bool force_our = false) const;
-     std::shared_ptr<http_response> not_found_page(details::modded_request* mr) const;
+     std::shared_ptr<http_response> method_not_allowed_page(detail::modded_request* mr) const;
+     std::shared_ptr<http_response> internal_error_page(detail::modded_request* mr, bool force_our = false) const;
+     std::shared_ptr<http_response> not_found_page(detail::modded_request* mr) const;
      bool should_skip_auth(const std::string& path) const;
 
      static void request_completed(void *cls,
@@ -331,17 +331,17 @@ class webserver {
                                  struct MHD_UpgradeResponseHandle *urh);
 #endif  // HAVE_WEBSOCKET
 
-     MHD_Result requests_answer_first_step(MHD_Connection* connection, struct details::modded_request* mr);
+     MHD_Result requests_answer_first_step(MHD_Connection* connection, struct detail::modded_request* mr);
 
      MHD_Result requests_answer_second_step(MHD_Connection* connection,
              const char* method, const char* version, const char* upload_data,
-             size_t* upload_data_size, struct details::modded_request* mr);
+             size_t* upload_data_size, struct detail::modded_request* mr);
 
-     MHD_Result finalize_answer(MHD_Connection* connection, struct details::modded_request* mr, const char* method);
+     MHD_Result finalize_answer(MHD_Connection* connection, struct detail::modded_request* mr, const char* method);
 
-     struct MHD_Response* get_raw_response_with_fallback(details::modded_request* mr);
+     struct MHD_Response* get_raw_response_with_fallback(detail::modded_request* mr);
 
-     MHD_Result complete_request(MHD_Connection* connection, struct details::modded_request* mr, const char* version, const char* method);
+     MHD_Result complete_request(MHD_Connection* connection, struct detail::modded_request* mr, const char* version, const char* method);
 
      void invalidate_route_cache();
 

src/webserver.cpp

@@ -228,7 +228,7 @@ void webserver::request_completed(void *cls, struct MHD_Connection *connection,
     std::ignore = connection;
     std::ignore = toe;
 
-    delete static_cast<details::modded_request*>(*con_cls);
+    delete static_cast<detail::modded_request*>(*con_cls);
 }
 
 bool webserver::register_resource(const std::string& resource, http_resource* hrm, bool family) {
@@ -240,18 +240,18 @@ bool webserver::register_resource(const std::string& resource, http_resource* hr
         throw std::invalid_argument("The resource should be '' or '/' and be marked as family when using a single_resource server");
     }
 
-    details::http_endpoint idx(resource, family, true, regex_checking);
+    detail::http_endpoint idx(resource, family, true, regex_checking);
 
     std::unique_lock registered_resources_lock(registered_resources_mutex);
-    pair<map<details::http_endpoint, http_resource*>::iterator, bool> result = registered_resources.insert(map<details::http_endpoint, http_resource*>::value_type(idx, hrm));
+    pair<map<detail::http_endpoint, http_resource*>::iterator, bool> result = registered_resources.insert(map<detail::http_endpoint, http_resource*>::value_type(idx, hrm));
 
     if (result.second) {
         bool is_exact = !family && idx.get_url_pars().empty();
         if (is_exact) {
             registered_resources_str.insert(pair<string, http_resource*>(idx.get_url_complete(), result.first->second));
         }
         if (idx.is_regex_compiled()) {
-            registered_resources_regex.insert(map<details::http_endpoint, http_resource*>::value_type(idx, hrm));
+            registered_resources_regex.insert(map<detail::http_endpoint, http_resource*>::value_type(idx, hrm));
         }
         registered_resources_lock.unlock();
         invalidate_route_cache();
@@ -572,7 +572,7 @@ void webserver::invalidate_route_cache() {
 
 void webserver::unregister_resource(const string& resource) {
     // family does not matter - it just checks the url_normalized anyhow
-    details::http_endpoint he(resource, false, true, regex_checking);
+    detail::http_endpoint he(resource, false, true, regex_checking);
     std::unique_lock registered_resources_lock(registered_resources_mutex);
 
     // Invalidate cache while holding registered_resources_mutex to prevent
@@ -775,7 +775,7 @@ void* uri_log(void* cls, const char* uri, struct MHD_Connection *con) {
     std::ignore = cls;
     std::ignore = con;
 
-    auto mr = std::make_unique<details::modded_request>();
+    auto mr = std::make_unique<detail::modded_request>();
     // MHD may invoke this callback with a null uri before the request line
     // has been parsed (e.g. port scans, half-open connections, or non-HTTP
     // traffic on the listening port). Treat that as an empty URI so the
@@ -830,7 +830,7 @@ MHD_Result webserver::post_iterator(void *cls, enum MHD_ValueKind kind,
     // Parameter needed to respect MHD interface, but not needed here.
     std::ignore = kind;
 
-    struct details::modded_request* mr = (struct details::modded_request*) cls;
+    struct detail::modded_request* mr = (struct detail::modded_request*) cls;
 
     if (!filename) {
         // There is no actual file, just set the arg key/value and return.
@@ -1016,23 +1016,23 @@ void webserver::upgrade_handler(void *cls, struct MHD_Connection* connection,
 }
 #endif  // HAVE_WEBSOCKET
 
-std::shared_ptr<http_response> webserver::not_found_page(details::modded_request* mr) const {
+std::shared_ptr<http_response> webserver::not_found_page(detail::modded_request* mr) const {
     if (not_found_resource != nullptr) {
         return not_found_resource(*mr->dhr);
     } else {
         return std::make_shared<string_response>(std::string{constants::NOT_FOUND_ERROR}, http_utils::http_not_found);
     }
 }
 
-std::shared_ptr<http_response> webserver::method_not_allowed_page(details::modded_request* mr) const {
+std::shared_ptr<http_response> webserver::method_not_allowed_page(detail::modded_request* mr) const {
     if (method_not_allowed_resource != nullptr) {
         return method_not_allowed_resource(*mr->dhr);
     } else {
         return std::make_shared<string_response>(std::string{constants::METHOD_ERROR}, http_utils::http_method_not_allowed);
     }
 }
 
-std::shared_ptr<http_response> webserver::internal_error_page(details::modded_request* mr, bool force_our) const {
+std::shared_ptr<http_response> webserver::internal_error_page(detail::modded_request* mr, bool force_our) const {
     if (internal_error_resource != nullptr && !force_our) {
         return internal_error_resource(*mr->dhr);
     } else {
@@ -1081,7 +1081,7 @@ bool webserver::should_skip_auth(const std::string& path) const {
     return false;
 }
 
-MHD_Result webserver::requests_answer_first_step(MHD_Connection* connection, struct details::modded_request* mr) {
+MHD_Result webserver::requests_answer_first_step(MHD_Connection* connection, struct detail::modded_request* mr) {
     mr->dhr.reset(new http_request(connection, unescaper));
     mr->dhr->set_file_cleanup_callback(file_cleanup_callback);
 
@@ -1106,7 +1106,7 @@ MHD_Result webserver::requests_answer_first_step(MHD_Connection* connection, str
 
 MHD_Result webserver::requests_answer_second_step(MHD_Connection* connection, const char* method,
         const char* version, const char* upload_data,
-        size_t* upload_data_size, struct details::modded_request* mr) {
+        size_t* upload_data_size, struct detail::modded_request* mr) {
     if (0 == *upload_data_size) return complete_request(connection, mr, version, method);
 
     if (mr->has_body) {
@@ -1134,7 +1134,7 @@ MHD_Result webserver::requests_answer_second_step(MHD_Connection* connection, co
     return MHD_YES;
 }
 
-struct MHD_Response* webserver::get_raw_response_with_fallback(details::modded_request* mr) {
+struct MHD_Response* webserver::get_raw_response_with_fallback(detail::modded_request* mr) {
     try {
         struct MHD_Response* raw = mr->dhrs->get_raw_response();
         if (raw == nullptr) {
@@ -1159,7 +1159,7 @@ struct MHD_Response* webserver::get_raw_response_with_fallback(details::modded_r
     }
 }
 
-MHD_Result webserver::finalize_answer(MHD_Connection* connection, struct details::modded_request* mr, const char* method) {
+MHD_Result webserver::finalize_answer(MHD_Connection* connection, struct detail::modded_request* mr, const char* method) {
     int to_ret = MHD_NO;
 
 #ifdef HAVE_WEBSOCKET
@@ -1231,7 +1231,7 @@ MHD_Result webserver::finalize_answer(MHD_Connection* connection, struct details
             fe = registered_resources_str.find(st_url);
             if (fe == registered_resources_str.end()) {
                 if (regex_checking) {
-                    details::http_endpoint endpoint(st_url, false, false, false);
+                    detail::http_endpoint endpoint(st_url, false, false, false);
 
                     // Data needed for parameter extraction after match.
                     // On cache hit, we copy these while holding the cache lock
@@ -1256,7 +1256,7 @@ MHD_Result webserver::finalize_answer(MHD_Connection* connection, struct details
 
                     if (!found) {
                         // Cache miss — perform regex scan
-                        map<details::http_endpoint, http_resource*>::iterator found_endpoint;
+                        map<detail::http_endpoint, http_resource*>::iterator found_endpoint;
 
                         size_t len = 0;
                         size_t tot_len = 0;
@@ -1368,7 +1368,7 @@ MHD_Result webserver::finalize_answer(MHD_Connection* connection, struct details
     return (MHD_Result) to_ret;
 }
 
-MHD_Result webserver::complete_request(MHD_Connection* connection, struct details::modded_request* mr, const char* version, const char* method) {
+MHD_Result webserver::complete_request(MHD_Connection* connection, struct detail::modded_request* mr, const char* version, const char* method) {
     mr->ws = this;
 
     mr->dhr->set_path(mr->standardized_url);
@@ -1380,7 +1380,7 @@ MHD_Result webserver::complete_request(MHD_Connection* connection, struct detail
 
 MHD_Result webserver::answer_to_connection(void* cls, MHD_Connection* connection, const char* url, const char* method,
         const char* version, const char* upload_data, size_t* upload_data_size, void** con_cls) {
-    struct details::modded_request* mr = static_cast<struct details::modded_request*>(*con_cls);
+    struct detail::modded_request* mr = static_cast<struct detail::modded_request*>(*con_cls);
 
     if (mr->dhr) {
         return static_cast<webserver*>(cls)->requests_answer_second_step(connection, method, version, upload_data, upload_data_size, mr);