Return all health errors instead of just the first one

[ahrtr]

During each reconciliation process, etcd-operator performs health check on all etcd members. Currently it just returns the first error if any. We should return all errors instead.

etcd-operator/internal/controller/utils.go

Lines 543 to 549 in 6791fdc

	for _, healthInfo := range healthInfos {
	if !healthInfo.Health {
	// TODO: also update metrics?
	return memberlistResp, healthInfos, errors.New(healthInfo.String())
	}
	lg.Info(healthInfo.String())
	}

[GunaKKIBM]

/assign

[GunaKKIBM]

#274 @ahrtr I have raised the PR.
I have a query, as of now, these errors are not seen anywhere in the cluster, would it be a good idea to publish it as events against the CR instance?

[ahrtr]

#274 @ahrtr I have raised the PR.

Merged. thx

I have a query, as of now, these errors are not seen anywhere in the cluster, would it be a good idea to publish it as events against the CR instance?

The errors will be show up in the log at least for now. It's open to discussion whether we should get them included in status or event after we release v0.2.0