From bf40df9b8b4eb4a95437e8df47ed318e78505410 Mon Sep 17 00:00:00 2001 From: Michael Ficarra Date: Wed, 15 Apr 2020 19:37:54 +0300 Subject: [PATCH 1/2] Version 5.1.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 76e0bfe..f840a9c 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,7 @@ "description": "ECMAScript JS AST traversal functions", "homepage": "https://github.com/estools/estraverse", "main": "estraverse.js", - "version": "5.0.0", + "version": "5.1.0", "engines": { "node": ">=4.0" }, From 74288555bb3a6d4415f5413d138747bdaee3f518 Mon Sep 17 00:00:00 2001 From: Niv Date: Thu, 23 Jul 2020 16:42:18 +0300 Subject: [PATCH 2/2] Increase cursor instead of using splice on comments array, which is a very expensive operation and cause a performance issue for large files with many comments. --- estraverse.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/estraverse.js b/estraverse.js index b7db020..01f2858 100644 --- a/estraverse.js +++ b/estraverse.js @@ -732,10 +732,8 @@ node.leadingComments = []; } node.leadingComments.push(comment); - comments.splice(cursor, 1); - } else { - cursor += 1; } + cursor++; } // already out of owned node @@ -765,10 +763,8 @@ node.trailingComments = []; } node.trailingComments.push(comment); - comments.splice(cursor, 1); - } else { - cursor += 1; } + cursor++; } // already out of owned node