Skip to content

Conversation

@SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Dec 7, 2025

Description of Change

Add a new Matter endpoint for window covering, including example and documentation.

Test Scenarios

Using Alexa and the ESP32-S3 with the provided example.
CI

Related links

None

@SuGlider SuGlider added this to the 3.3.0 milestone Dec 7, 2025
@SuGlider SuGlider self-assigned this Dec 7, 2025
@SuGlider SuGlider added the Area: Matter Issues and Feature Request about Matter Protocol label Dec 7, 2025
@SuGlider SuGlider moved this from Todo to In Progress in Arduino ESP32 Core Project Roadmap Dec 7, 2025
@SuGlider SuGlider requested a review from P-R-O-C-H-Y December 7, 2025 02:26
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Messages
📖 This PR seems to be quite large (total lines of code: 2211), you might consider splitting it into smaller PRs

👋 Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8fce4ab

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Test Results

 83 files   83 suites   26m 3s ⏱️
 55 tests  55 ✅ 0 💤 0 ❌
598 runs  598 ✅ 0 💤 0 ❌

Results for commit 8fce4ab.

♻️ This comment has been updated with latest results.

@SuGlider SuGlider marked this pull request as draft December 7, 2025 03:43
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32S30⚠️ +9240.00⚠️ +0.05000.000.00
ESP32S20⚠️ +9240.00⚠️ +0.06000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP320⚠️ +9240.00⚠️ +0.05000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Matter/examples/MatterColorLight00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterCommissionTest00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterComposedLights00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterContactSensor00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterDimmableLight00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterEnhancedColorLight00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterEvents00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterFan00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterHumiditySensor00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterMinimum00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterOccupancySensor00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterOnIdentify00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterOnOffLight00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterOnOffPlugin00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterPressureSensor00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterRainSensor00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterSmartButton00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterTemperatureLight00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterTemperatureSensor00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterThermostat00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterWaterFreezeDetector00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterWaterLeakDetector00⚠️ +9240⚠️ +9240000000⚠️ +9240
libraries/Matter/examples/MatterWindowCovering--------------

@SuGlider SuGlider marked this pull request as ready for review December 7, 2025 04:05
@SuGlider SuGlider moved this from In Progress to In Review in Arduino ESP32 Core Project Roadmap Dec 7, 2025
@SuGlider SuGlider added the Status: Review needed Issue or PR is awaiting review label Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Matter Issues and Feature Request about Matter Protocol Status: Review needed Issue or PR is awaiting review

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants