From 76907125413fbe90183ff489a560218ffcee6386 Mon Sep 17 00:00:00 2001
From: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Date: Tue, 2 Dec 2025 09:43:08 -0300
Subject: [PATCH 1/2] fix(ble): Add missing modifier keys for HID Keyboard

---
 libraries/BLE/src/HIDKeyboardTypes.h | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/libraries/BLE/src/HIDKeyboardTypes.h b/libraries/BLE/src/HIDKeyboardTypes.h
index 971d637f961..37dda68c6ec 100644
--- a/libraries/BLE/src/HIDKeyboardTypes.h
+++ b/libraries/BLE/src/HIDKeyboardTypes.h
@@ -21,14 +21,28 @@
 #ifndef KEYBOARD_DEFS_H
 #define KEYBOARD_DEFS_H
 
+#include "esp_bit_defs.h"
+
 #define REPORT_ID_KEYBOARD 1
 #define REPORT_ID_VOLUME   3
 
 /* Modifiers */
 enum MODIFIER_KEY {
-  KEY_CTRL = 1,
-  KEY_SHIFT = 2,
-  KEY_ALT = 4,
+  /* Aliases for the left modifiers */
+  KEY_CTRL = BIT(0),
+  KEY_SHIFT = BIT(1),
+  KEY_ALT = BIT(2),
+  KEY_GUI = BIT(3),  /*!< GUI key (Command on macOS, Windows key on Windows) */
+  /* Left modifiers */
+  KEY_LEFT_CTRL = BIT(0),
+  KEY_LEFT_SHIFT = BIT(1),
+  KEY_LEFT_ALT = BIT(2),
+  KEY_LEFT_GUI = BIT(3),
+  /* Right modifiers */
+  KEY_RIGHT_CTRL = BIT(4),
+  KEY_RIGHT_SHIFT = BIT(5),
+  KEY_RIGHT_ALT = BIT(6),
+  KEY_RIGHT_GUI = BIT(7),
 };
 
 enum MEDIA_KEY {

From 78f8552e408f38ecd81fe5c092e2d99a42dc6d8a Mon Sep 17 00:00:00 2001
From: "pre-commit-ci-lite[bot]"
 <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Date: Tue, 2 Dec 2025 14:33:10 +0000
Subject: [PATCH 2/2] ci(pre-commit): Apply automatic fixes

---
 libraries/BLE/src/HIDKeyboardTypes.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libraries/BLE/src/HIDKeyboardTypes.h b/libraries/BLE/src/HIDKeyboardTypes.h
index 37dda68c6ec..e0b40ebafc3 100644
--- a/libraries/BLE/src/HIDKeyboardTypes.h
+++ b/libraries/BLE/src/HIDKeyboardTypes.h
@@ -32,7 +32,7 @@ enum MODIFIER_KEY {
   KEY_CTRL = BIT(0),
   KEY_SHIFT = BIT(1),
   KEY_ALT = BIT(2),
-  KEY_GUI = BIT(3),  /*!< GUI key (Command on macOS, Windows key on Windows) */
+  KEY_GUI = BIT(3), /*!< GUI key (Command on macOS, Windows key on Windows) */
   /* Left modifiers */
   KEY_LEFT_CTRL = BIT(0),
   KEY_LEFT_SHIFT = BIT(1),