Skip to content

Conversation

@me-no-dev
Copy link
Member

This pull request introduces improved error reporting for the OTA update process in ESP_HostedOTA.cpp. The code now provides more specific feedback when the update file is not found or when other HTTP errors occur.

Error handling improvements:

  • Added a check for HTTP_CODE_NOT_FOUND and a corresponding error message when the update file is missing.
  • Added a generic error message for other HTTP error codes, including the code in the output for easier debugging.

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 7d136fd

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Test Results

 76 files   76 suites   16m 15s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 7d136fd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4
ExampleFLASHRAM
libraries/ESP_HostedOTA/examples/ESP_HostedOTA--

@me-no-dev me-no-dev merged commit 3239ee2 into master Dec 2, 2025
72 of 80 checks passed
@me-no-dev me-no-dev deleted the feat/hosted_ota_log branch December 2, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants