Skip to content

Commit ba2f16d

Browse files
DaneSlatteryDane Slattery
andauthored
Change long form of save-image --ignore-app-descriptor (#974)
* Change long form of save-image --ignore-app-descriptor * fix fmt * Update changelog * support alias * format --------- Co-authored-by: Dane Slattery <dane@polarmonitoring.com>
1 parent 1efe57a commit ba2f16d

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1919

2020
- Updated bootloaders with `release/v5.5` ones from IDF (#976)
2121

22+
- The CLI argument `save-image`, `ignore-app-descriptor` is now consistent with other args (#974)
23+
2224
### Fixed
2325

2426
- Corrected eFuse BLOCK0 definitions for ESP32-C2, ESP32-C3, and ESP32-S3 (#961)

espflash/src/cli/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,8 +259,8 @@ pub struct ImageArgs {
259259
#[arg(long, value_name = "MMU_PAGE_SIZE", value_parser = parse_u32)]
260260
pub mmu_page_size: Option<u32>,
261261
/// Skip checking whether the app descriptor is present in the image.
262-
#[arg(long = "ignore_app_descriptor", default_value_t = true, action = clap::ArgAction::SetFalse)]
263-
pub check_app_descriptor: bool,
262+
#[arg(long = "ignore-app-descriptor", visible_alias ="ignore_app_descriptor",default_value_t = true, action = clap::ArgAction::SetFalse)]
263+
pub check_app_descriptor: bool, // todo: remove ignore_app_descriptor alias before v5
264264
}
265265

266266
/// ESP-IDF image format arguments

0 commit comments

Comments
 (0)