From f68fa71181f77c50c0b270ef456e901e046f0ff6 Mon Sep 17 00:00:00 2001 From: Erik Darling <2136037+erikdarlingdata@users.noreply.github.com> Date: Sat, 7 Mar 2026 13:33:04 -0600 Subject: [PATCH] Fix FinOps CI failures: sql_variant CONCAT and test table count - CONVERT SERVERPROPERTY results to nvarchar(128) in CONCAT call to avoid implicit sql_variant conversion error (Msg 257) - Update SchemaStatements_MatchTableCount assertion from 24 to 26 for the two new FinOps tables (database_size_stats, server_properties) Co-Authored-By: Claude Opus 4.6 --- Lite.Tests/DuckDbSchemaTests.cs | 4 ++-- install/53_collect_server_properties.sql | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Lite.Tests/DuckDbSchemaTests.cs b/Lite.Tests/DuckDbSchemaTests.cs index a0460b3..e30dbc9 100644 --- a/Lite.Tests/DuckDbSchemaTests.cs +++ b/Lite.Tests/DuckDbSchemaTests.cs @@ -136,8 +136,8 @@ public void SchemaStatements_MatchTableCount() foreach (var _ in Schema.GetAllTableStatements()) tableCount++; - /* 24 tables from Schema (schema_version is created separately by DuckDbInitializer) */ - Assert.Equal(24, tableCount); + /* 26 tables from Schema (schema_version is created separately by DuckDbInitializer) */ + Assert.Equal(26, tableCount); } [Fact] diff --git a/install/53_collect_server_properties.sql b/install/53_collect_server_properties.sql index 9cf046e..6bdce6f 100644 --- a/install/53_collect_server_properties.sql +++ b/install/53_collect_server_properties.sql @@ -212,9 +212,9 @@ BEGIN N'SHA2_256', CONCAT ( - SERVERPROPERTY(N'Edition'), N'|', - SERVERPROPERTY(N'ProductVersion'), N'|', - SERVERPROPERTY(N'ProductLevel'), N'|', + CONVERT(nvarchar(128), SERVERPROPERTY(N'Edition')), N'|', + CONVERT(nvarchar(128), SERVERPROPERTY(N'ProductVersion')), N'|', + CONVERT(nvarchar(128), SERVERPROPERTY(N'ProductLevel')), N'|', @engine_edition, N'|', (SELECT osi.cpu_count FROM sys.dm_os_sys_info AS osi), N'|', (SELECT osi.physical_memory_kb FROM sys.dm_os_sys_info AS osi), N'|',