References to unresolvable server

[JanMkl]

In the python-sample-app README.md and charts/eric-oss-hello-world-python-app there are references to an arm docker.rnd.ericsson.se which is a unresolvable host.

% host armdocker.rnd.ericsson.se
Host armdocker.rnd.ericsson.se not found: 3(NXDOMAIN)

If these are meant to be examples that should be replaced with real values then a good style would be to use example.com to indicate that the user should replace the value with some real value. If these are not examples then DNS domain table should be fixed so that the host is resolvable.

List of files that contain references to armdocker.ericsson.se:

README.md
charts/eric-oss-hello-world-python-app/templates/_helpers.tpl
charts/eric-oss-hello-world-python-app/values.yaml
charts/eric-oss-hello-world-python-app/eric-product-info.yaml

[dueyfinster]

Thanks for your feedback Jan - we're working to make this repository the source of truth and remove all internal only Ericsson domains - bear with us while we do this. The App Packaging tool we want to try and open source also, and the app itself can use any standard Python image as mentioned in the README.

I'll leave this open and update when I can show more - watch this issue/space ! 😃

[imgios]

I think a workaround for the registry would be to replace it with the GitHub Container Registry. The python-sample-app container image could be built and released in the GHCR, and the chart-related files could use the GHCR reference instead of the armdocker.rnd.ericsson.se reference.

If you guys (@codeowners) agree, I can also make a Pull Request to address that.

[dueyfinster]

@imgios app packaging tool hasn't been open sourced, but it's available here to download (assuming you have access, if not email the support): https://developer.intelligentautomationplatform.ericsson.net/#capabilities/app-administration/tutorial-package-app?chapter=download

What it does is package it as a CSAR and does checking etc. Here's a ref on CSAR:
https://docs.onap.org/projects/onap-sdc/en/latest/onboardingpackages.html

the app's docker image can be standard python, available on all the big public registries.

So the only tie really to that registry is the App Packaging Tool. I'll contact the team responsible for it and give them the feedback we'd ideally like to see it on a public registry. No promises as it's not my teams area 👍🏻 (But I would like to see it personally).

[imgios]

I see your point. Indeed, I wasn't referring to the App Packaging Tool, which isn't open source (yet? 😄 ). I was wondering whether you could provide a working Helm chart sample with the following changes:

1. Build the python-sample-app using a public Python image as baseline
2. Publish the python-sample-app Container in the repository Container Registry

Points 1 and 2 could be done via a GitHub workflow (maybe triggered whenever a new repository tag/release is created)

3. Update the sample Helm Chart files with the python-sample-app container image reference to fetch it from the repository Container Registry:

https://github.com/ericsson-iap/python-sample-app/blob/main/charts/eric-oss-hello-world-python-app/templates/_helpers.tpl#L51

https://github.com/ericsson-iap/python-sample-app/blob/main/charts/eric-oss-hello-world-python-app/values.yaml#L7

https://github.com/ericsson-iap/python-sample-app/blob/main/charts/eric-oss-hello-world-python-app/eric-product-info.yaml#L7-L9

In this way, at least the sample Helm chart does not refer to any restricted Ericsson resources.