-
Notifications
You must be signed in to change notification settings - Fork 80
Open
Description
Hi
Just wanted to mention some issues I noticed
-
You should add the Content-Type: application/json to the headers you send
-
When you decode the server's response and you check for the result key in the object, you then call
callback(null, decoded.result);
but if you find the error key you invoke the callback as
callback(decoded.error);
Why would you send the null?
Why not just use
callback(response)
Other than these, great work
Metadata
Metadata
Assignees
Labels
No labels