Skip to content

Building from current source freezes on clip length changes/Current repo different than 1.04 source? #31

@nyboer

Description

@nyboer

I'm making some modifications for my own evil needs. I tried some with success, but noticed that when I change the clip length, it freezes with error: “continue_immediately” is not a supported value. Digging into it, I find these lines in "DrumSequenceMode.java":
private void adjustMode(final int notes) {
if (notes % 8 == 0) {
cursorClip.launchMode().set("play_with_quantization");
} else if (clipLaunchModeQuant.get()) {
cursorClip.launchMode().set("continue_with_quantization");
} else {
cursorClip.launchMode().set("continue_immediately");
}
}

When I look at the API docs, I see:
Possible values are: - default - from_start - continue_or_from_start - continue_or_synced - synced:

When I look at the source provided with the most recent 1.04 build, I see:

private void adjustMode(final int notes) {
    if (notes % 8 == 0) {
        cursorClip.launchMode().set("default");
    } else if (clipLaunchModeQuant.get()) {
        cursorClip.launchMode().set("synced");
    } else {
        cursorClip.launchMode().set("from_start");
    }
}

I'm confused why the latest repo from before the latest release is different from the latest release source, but I'm more confused about the values used in the source that do not seem to be part of the API! I can just change these lines in my branch ok, but would love to understand what's going on!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions