Skip to content

Commit 42e5703

Browse files
committed
building ecr image dynamically
1 parent b1a1df0 commit 42e5703

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

.github/workflows/node-api-cicd.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,17 +107,16 @@ jobs:
107107
env:
108108
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
109109
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
110-
AWS_REGION: ${{ env.AWS_REGION }}
111-
ECR_REGISTRY: ${{ needs.build-and-push.outputs.ecr_registry }}
112-
API_IMAGE: ${{ needs.build-and-push.outputs.image_uri }}
110+
AWS_REGION: ${{ secrets.AWS_REGION }}
113111
VPS_DEPLOY_PATH: ${{ env.VPS_DEPLOY_PATH }}
114112
APP_ENV_B64: ${{ secrets.APP_ENV_B64 }}
113+
ECR_REPOSITORY: ${{ secrets.ECR_REPOSITORY }}
115114
with:
116115
host: ${{ secrets.VPS_HOST }}
117116
username: ${{ secrets.VPS_USER }}
118117
key: ${{ secrets.VPS_SSH_KEY }}
119118
port: ${{ secrets.VPS_PORT || 22 }}
120-
envs: AWS_ACCESS_KEY_ID,AWS_SECRET_ACCESS_KEY,AWS_REGION,ECR_REGISTRY,API_IMAGE,VPS_DEPLOY_PATH,APP_ENV_B64
119+
envs: AWS_ACCESS_KEY_ID,AWS_SECRET_ACCESS_KEY,AWS_REGION,VPS_DEPLOY_PATH,APP_ENV_B64,ECR_REPOSITORY
121120
script: |
122121
set -e
123122
command -v docker >/dev/null 2>&1 || { echo "docker is not installed"; exit 1; }
@@ -132,10 +131,13 @@ jobs:
132131
fi
133132
printf "%s" "$APP_ENV_B64" | base64 -d > .env
134133
docker logout 2>/dev/null || true
135-
echo "Logging into ECR: $ECR_REGISTRY"
136134
export AWS_ACCESS_KEY_ID="$AWS_ACCESS_KEY_ID"
137135
export AWS_SECRET_ACCESS_KEY="$AWS_SECRET_ACCESS_KEY"
138136
export AWS_REGION="$AWS_REGION"
137+
AWS_ACCOUNT_ID=$(aws sts get-caller-identity --query Account --output text)
138+
ECR_REGISTRY="${AWS_ACCOUNT_ID}.dkr.ecr.${AWS_REGION}.amazonaws.com"
139+
API_IMAGE="${ECR_REGISTRY}/${ECR_REPOSITORY}:latest"
140+
echo "Logging into ECR: $ECR_REGISTRY"
139141
aws ecr get-login-password --region "$AWS_REGION" | docker login --username AWS --password-stdin "$ECR_REGISTRY"
140142
echo "ECR login exit code: $?"
141143
echo "Pulling postgres image..."

0 commit comments

Comments
 (0)