fix(code-browser): hide file search when viewing a file#1258
Open
sunlight7777777 wants to merge 1 commit into
Open
fix(code-browser): hide file search when viewing a file#1258sunlight7777777 wants to merge 1 commit into
sunlight7777777 wants to merge 1 commit into
Conversation
anderdc
added
enhancement
anderdc
requested changes
May 22, 2026
Collaborator
anderdc
left a comment
anderdc
left a comment
There was a problem hiding this comment.
Please scope this down to what #1256 asks for. Keep: the RepositoryCodeBrowser.tsx change wrapping GoToFileSearch in {!isFile && (...)}. Drop: the package-lock.json changes — they remove @heroicons/react, @mui/lab, @types/dompurify, and react-tooltip and aren't mentioned in the description. That's a lockfile regeneration unrelated to #1256; revert package-lock.json so this PR is just the one-file fix.
sunlight7777777
force-pushed
the
fix/hide-search-on-file-view
branch
from
4766002 to
959cb44
Compare
Author
|
@anderdc fixed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Search files and folders" input was still rendered when a file
was open, even though there's no file list to filter at that point.
Conditionally render GoToFileSearch only in directory view.
Screenshots
(attach Image 1: repo root showing folders/files)
.env.example) — search input should not be shown here:(attach Image 2: opened file contents)
Fixes #1256