Skip to content

feat: repository issues table toolbar#1163

Open
andriypolanski wants to merge 5 commits into
entrius:testfrom
andriypolanski:feat/repository-issues-table-toolbar
Open

feat: repository issues table toolbar#1163
andriypolanski wants to merge 5 commits into
entrius:testfrom
andriypolanski:feat/repository-issues-table-toolbar

Conversation

@andriypolanski
Copy link
Copy Markdown
Contributor

@andriypolanski andriypolanski commented May 14, 2026

Summary

The repository Issues table toolbar lacked client-side search, filter pills had uneven label/count presentation, and the header layout did not adapt well on small screens (no compact search entry point, filters competing with the title on one wrapped row).

Related Issues

Closes #1164

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Screenshots

Before

before.mp4

After

after.mp4

Checklist

  • New components are modularized/separated where sensible
  • Uses predefined theme (e.g. no hardcoded colors)
  • Responsive/mobile checked
  • Tested against the test API
  • npm run format and npm run lint:fix have been run
  • npm run build passes
  • Screenshots included for any UI/visual changes

Solution

  1. Client-side search (RepositoryIssuesTable.tsx)
  2. Filter button alignment (FilterButton.tsx)
  3. Responsive issues toolbar (RepositoryIssuesTable.tsx)

Files

File Change
src/components/repositories/RepositoryIssuesTable.tsx Search pipeline, toolbar layout, mobile search, empty copy
src/components/FilterButton.tsx Shared pill alignment / typography (all usages)

@xiao-xiao-mao xiao-xiao-mao Bot added the enhancement New feature or request label May 14, 2026
@andriypolanski
Copy link
Copy Markdown
Contributor Author

Hi @anderdc,

First of all, thanks for taking the time to review.

I opened this PR as an updated version because #738 was closed without being resolved.

Please review it when you have a chance. If there are any other issues, feel free to leave a comment and I’ll fix them as soon as possible.

Thanks again.

@anderdc
Copy link
Copy Markdown
Collaborator

anderdc commented May 17, 2026

fix conflicts

Copy link
Copy Markdown
Collaborator

@anderdc anderdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two blockers before this can merge:

  1. The toolbar and search UI don't match the sibling RepositoryPRsTable, so the two repository tables now look like different products. RepositoryPRsTable keeps one horizontal toolbar row (title + filter Stack, space-between) and its search is AuthorFilter — a button that opens a popover containing the search field. This PR instead splits the toolbar into two stacked rows, adds an always-visible inline TextField (different border radius and background than AuthorFilter's field), and introduces a mobile expand-icon with open/close state that no other table has. Rebuild the toolbar to match RepositoryPRsTable: single-row layout, and use the existing AuthorFilter-style search affordance rather than a new inline one. The search-filtering logic (issueMatchesSearch, searchFilteredIssues, count integration) and the FilterButton typography change are fine to keep.

  2. The pagination-reset effect — useEffect(() => setPage(0), [filter, sortKey, sortDirection]) — omits searchQuery. On page 2+, typing a search that narrows results leaves page stale, pagedIssues slices past the end of the array, and the table renders "No issues found" even though matches exist. Add searchQuery to that dependency array.

@andriypolanski
Copy link
Copy Markdown
Contributor Author

andriypolanski commented May 22, 2026

I just fixed always-visible inline TextField as you required, but RepositoryPRsTable provide filter functionality by Author value, but this pr provide search functionality by 3 values includes issue number, title and author.
And the table has not author column, so I'm gonna fix as you required, could you please let me know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repository Issues tab — no search, weak filter pills, cramped mobile toolbar

2 participants