feat : Standardize miner table pagination and shared pager UX#1059
feat : Standardize miner table pagination and shared pager UX#1059carlh7777 wants to merge 3 commits into
Conversation
|
Skipping in this review pass — branch has merge conflicts against current |
60c3676 to
cf862ed
Compare
|
Hi @ventura-oss Rebased onto the latest origin/test, resolved the merge conflicts, and force-pushed the updated branch for re-review. |
f98a638 to
3b31267
Compare
|
fix conflicts |
3b31267 to
f466de5
Compare
|
Hi @anderdc fixed conflicts |
|
fix conflicts again, this was caused by a PR I just merged |
f466de5 to
0e25363
Compare
|
Hi @anderdc fixed conflicts |
0e25363 to
aee091c
Compare
…Table and MinerRepositoriesTable
aee091c to
c69deb6
Compare
anderdc
left a comment
There was a problem hiding this comment.
The description says pagination is unified across Miner PRs, Repositories, and Score Breakdown tables, but the diff only migrates the Miner PRs table. Two things to fix:
-
The
TablePagination.tsxtop docstring and the PR description reference a Score Breakdown table andscorePage/scoreRowsparams — neither the table nor those params exist anywhere in the repo. Correct both to describe what the PR actually does: pagination for the Miner PRs table. -
Drop the
prPage→minerPagerename and the legacy-migration code (LEGACY_MINER_PAGE_PARAMS,stripLegacyMinerPaginationParams, and the legacy-key fallbacks inuseMinerExplorerPagination). One table uses this param — renaming it only adds migration scaffolding and churns existing deep links for no user-facing gain. KeepprPage.
The rows-per-page selector and numbered/mobile pager are fine — keep those.
…meters and remove legacy support
|
@anderdc Fixed all requested review comments. |
anderdc
left a comment
There was a problem hiding this comment.
Prior review items are resolved (docstring/description corrected, prPage kept, legacy migration dropped). Two leftovers from the dropped multi-table scope remain:
-
MinerTableRowsSelect.tsx docstring — "Rows-per-page control for table header toolbars (miner PR / repos tables)" names a repos table this PR doesn't touch, the same phantom reference that was flagged on the TablePagination.tsx docstring. Reword to the Miner PRs table only.
-
TablePagination.tsx — getMinerExplorerPaging returns rankOffset and pageSize, but the only caller (MinerPRsTable.tsx) destructures neither. Drop both from the return type and body.
Also: default page size drops from 20 to 10 (DEFAULT_MINER_EXPLORER_ROWS) and isn't mentioned in the description. Confirm intended or restore 20.
…fy paging return structure
|
Hi @anderdc Fixed the remaining review items |


Summary
prPage/prRows), including a rows-per-page selector.TablePagination.tsx.Type of Change
Screenshots
Before
Before.webm
After
After.webm
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses