fix linting

Entire-Checkpoint: 39b82e835037

Author: Soph

cmd/entire/cli/attach_test.go

@@ -81,6 +81,7 @@ func TestAttach_Success(t *testing.T) {
 	}
 	if state == nil {
 		t.Fatal("expected session state to be created")
+		return
 	}
 	if state.SessionID != sessionID {
 		t.Errorf("session ID = %q, want %q", state.SessionID, sessionID)
@@ -368,6 +369,7 @@ func TestAttach_GeminiSubdirectorySession(t *testing.T) {
 	}
 	if state == nil {
 		t.Fatal("expected session state to be created")
+		return
 	}
 	if state.AgentType != agent.AgentTypeGemini {
 		t.Errorf("AgentType = %q, want %q", state.AgentType, agent.AgentTypeGemini)
@@ -413,6 +415,7 @@ func TestAttach_GeminiSuccess(t *testing.T) {
 	}
 	if state == nil {
 		t.Fatal("expected session state to be created")
+		return
 	}
 	if state.AgentType != agent.AgentTypeGemini {
 		t.Errorf("AgentType = %q, want %q", state.AgentType, agent.AgentTypeGemini)
@@ -458,6 +461,7 @@ func TestAttach_CursorSuccess(t *testing.T) {
 	}
 	if state == nil {
 		t.Fatal("expected session state to be created")
+		return
 	}
 	if state.AgentType != agent.AgentTypeCursor {
 		t.Errorf("AgentType = %q, want %q", state.AgentType, agent.AgentTypeCursor)
@@ -506,6 +510,7 @@ func TestAttach_CodexSuccess(t *testing.T) {
 	}
 	if state == nil {
 		t.Fatal("expected session state to be created")
+		return
 	}
 	if state.AgentType != agent.AgentTypeCodex {
 		t.Errorf("AgentType = %q, want %q", state.AgentType, agent.AgentTypeCodex)
@@ -554,6 +559,7 @@ func TestAttach_FactoryAIDroidSuccess(t *testing.T) {
 	}
 	if state == nil {
 		t.Fatal("expected session state to be created")
+		return
 	}
 	if state.AgentType != agent.AgentTypeFactoryAIDroid {
 		t.Errorf("AgentType = %q, want %q", state.AgentType, agent.AgentTypeFactoryAIDroid)

cmd/entire/cli/search_tui_test.go

@@ -654,6 +654,7 @@ func TestSearchModel_SelectedResult(t *testing.T) {
 	r := m.selectedResult()
 	if r == nil {
 		t.Fatal("selectedResult() = nil, want first result")
+		return
 	}
 	if r.Data.ID != "a3b2c4d5e6f7" {
 		t.Errorf("selectedResult().Data.ID = %q, want %q", r.Data.ID, "a3b2c4d5e6f7")
@@ -664,6 +665,7 @@ func TestSearchModel_SelectedResult(t *testing.T) {
 	r = m.selectedResult()
 	if r == nil {
 		t.Fatal("selectedResult() at cursor 1 = nil")
+		return
 	}
 	if r.Data.ID != "d5e6f789ab01" {
 		t.Errorf("selectedResult().Data.ID = %q, want %q", r.Data.ID, "d5e6f789ab01")

cmd/entire/cli/sessions_test.go

@@ -100,6 +100,7 @@ func TestStopCmd_SingleSession_EmptyWorktreePath_Force(t *testing.T) {
 	}
 	if loaded == nil {
 		t.Fatal("expected session state to still exist after stop")
+		return
 	}
 	if loaded.Phase != session.PhaseEnded {
 		t.Errorf("expected Phase=PhaseEnded, got: %v", loaded.Phase)
@@ -191,6 +192,7 @@ func TestStopCmd_AlreadyStopped(t *testing.T) {
 	}
 	if loaded == nil {
 		t.Fatal("expected session state to still exist")
+		return
 	}
 	if loaded.Phase != session.PhaseEnded {
 		t.Errorf("expected Phase=PhaseEnded unchanged, got: %v", loaded.Phase)
@@ -225,6 +227,7 @@ func TestStopCmd_SessionFlag(t *testing.T) {
 	}
 	if target == nil {
 		t.Fatal("expected target session state to exist")
+		return
 	}
 	if target.Phase != session.PhaseEnded {
 		t.Errorf("expected target Phase=PhaseEnded, got: %v", target.Phase)
@@ -236,6 +239,7 @@ func TestStopCmd_SessionFlag(t *testing.T) {
 	}
 	if other == nil {
 		t.Fatal("expected other session state to exist")
+		return
 	}
 	if other.Phase == session.PhaseEnded {
 		t.Errorf("expected other session to remain non-ended, got: %v", other.Phase)
@@ -284,6 +288,7 @@ func TestStopCmd_AllFlag(t *testing.T) {
 		}
 		if loaded == nil {
 			t.Fatalf("expected session %s to exist after stop", id)
+			return
 		}
 		if loaded.Phase != session.PhaseEnded {
 			t.Errorf("expected session %s Phase=PhaseEnded, got: %v", id, loaded.Phase)
@@ -330,6 +335,7 @@ func TestStopCmd_AllFlag_IncludesAllWorktrees(t *testing.T) {
 		}
 		if loaded == nil {
 			t.Fatalf("expected session %s to exist after stop", id)
+			return
 		}
 		if loaded.Phase != session.PhaseEnded {
 			t.Errorf("expected session %s to be PhaseEnded, got: %v", id, loaded.Phase)
@@ -384,6 +390,7 @@ func TestStopCmd_AllAndSessionMutuallyExclusive(t *testing.T) {
 	}
 	if loaded == nil {
 		t.Fatal("expected session state to still exist")
+		return
 	}
 	if loaded.Phase == session.PhaseEnded {
 		t.Error("expected session to remain non-ended after mutual exclusion error")
@@ -473,6 +480,7 @@ func TestStopSelectedSessions_StopsAll(t *testing.T) {
 		}
 		if loaded == nil {
 			t.Fatalf("expected session %s to exist after batch stop", id)
+			return
 		}
 		if loaded.Phase != session.PhaseEnded {
 			t.Errorf("expected session %s to be PhaseEnded after batch stop, got: %v", id, loaded.Phase)
@@ -517,6 +525,7 @@ func TestStopCmd_AlreadyStopped_EndedAtOnly(t *testing.T) {
 	}
 	if loaded == nil {
 		t.Fatal("expected session state to still exist")
+		return
 	}
 	if loaded.Phase != session.PhaseIdle {
 		t.Errorf("expected Phase to remain PhaseIdle (legacy), got: %v", loaded.Phase)
@@ -606,6 +615,7 @@ func TestStopCmd_NoFlags_CrossWorktreeSession(t *testing.T) {
 	}
 	if loaded == nil {
 		t.Fatal("expected cross-worktree session to exist after stop")
+		return
 	}
 	if loaded.Phase != session.PhaseEnded {
 		t.Errorf("expected cross-worktree session to be PhaseEnded, got: %v", loaded.Phase)