Skip to content

Commit ed5414c

Browse files
committed
fix: clarify external checkpoint discovery warning
Entire-Checkpoint: d2972e70b180
1 parent 5cc87e5 commit ed5414c

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

cmd/entire/cli/strategy/push_common.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ func printSettingsCommitHint(ctx context.Context, target string) {
132132
if isSettingsTrackedByGit(ctx) {
133133
return
134134
}
135-
fmt.Fprintln(os.Stderr, "[entire] Note: Commit and push .entire/settings.json for entire.io to discover your remote checkpoint.")
135+
fmt.Fprintln(os.Stderr, "[entire] Note: Checkpoints were pushed to a separate checkpoint remote, but .entire/settings.json is not tracked. entire.io may not be able to find this checkpoint until that file is committed and pushed.")
136136
})
137137
}
138138

cmd/entire/cli/strategy/push_common_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -947,7 +947,8 @@ func TestPrintSettingsCommitHint(t *testing.T) {
947947
}
948948
os.Stderr = old
949949

950-
assert.Contains(t, buf.String(), "Commit and push .entire/settings.json")
950+
assert.Contains(t, buf.String(), ".entire/settings.json is not tracked")
951+
assert.Contains(t, buf.String(), "entire.io may not be able to find this checkpoint")
951952
})
952953

953954
t.Run("no hint when settings is tracked", func(t *testing.T) {
@@ -1014,7 +1015,7 @@ func TestPrintSettingsCommitHint(t *testing.T) {
10141015
}
10151016
os.Stderr = old
10161017

1017-
count := bytes.Count(buf.Bytes(), []byte("Commit and push"))
1018+
count := bytes.Count(buf.Bytes(), []byte(".entire/settings.json is not tracked"))
10181019
assert.Equal(t, 1, count, "hint should print exactly once, got %d", count)
10191020
})
10201021
}

0 commit comments

Comments
 (0)