Use async/await in libwebaudio.js. NFC #25902
Open
+112
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
webaudio_async
branch
from
e60ac0c to
99129e4
Compare
Collaborator
Author
|
View with "hide whitespace" |
sbc100
force-pushed
the
webaudio_async
branch
from
99129e4 to
bad69c1
Compare
Collaborator
|
What does using 'async' provide here? It increases code size, but otherwise seems nonfunctional? |
Collaborator
Author
|
Just modernizing the code, but maybe not worth in this case? If I can't find a way to make it is at least size neutral maybe I will just abandon. |
Collaborator
Author
|
(I do think it makes the code more readable in the modern form, avoid extra indentation etc, but not worth it in this case probably) |
Collaborator
|
My understanding is, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.