Skip to content

Commit c6f9259

Browse files
authored
[testing] Fix disable browser auto config. (#25384)
Can now use `--no-browser-auto-config` or the env variable.
1 parent b3fe7de commit c6f9259

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/runner.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,7 @@ def parse_args():
495495
help='Command to launch web browser in which to run browser tests.')
496496
parser.add_argument('--headless', action='store_true',
497497
help='Run browser tests in headless mode.', default=None)
498-
parser.add_argument('--browser-auto-config', type=bool, default=True,
498+
parser.add_argument('--browser-auto-config', action=argparse.BooleanOptionalAction, default=None,
499499
help='Use the default CI browser configuration.')
500500
parser.add_argument('tests', nargs='*')
501501
parser.add_argument('--failfast', action='store_true', help='If true, test run will abort on first failed test.')
@@ -533,7 +533,7 @@ def parse_args():
533533

534534
def configure():
535535
browser_common.EMTEST_BROWSER = os.getenv('EMTEST_BROWSER')
536-
browser_common.EMTEST_BROWSER_AUTO_CONFIG = os.getenv('EMTEST_BROWSER_AUTO_CONFIG')
536+
browser_common.EMTEST_BROWSER_AUTO_CONFIG = int(os.getenv('EMTEST_BROWSER_AUTO_CONFIG', '1'))
537537
browser_common.EMTEST_HEADLESS = int(os.getenv('EMTEST_HEADLESS', '0'))
538538
common.EMTEST_DETECT_TEMPFILE_LEAKS = int(os.getenv('EMTEST_DETECT_TEMPFILE_LEAKS', '0'))
539539
common.EMTEST_ALL_ENGINES = int(os.getenv('EMTEST_ALL_ENGINES', '0'))

0 commit comments

Comments
 (0)