DMA Buffers allocated in wrong section.

What's Wrong:

* Used dma_buffer instead of dma_buffers.

How Was it Fixed (if not obvious):

* Fixed strings.

What side effects does this have (could be none):

* DMA memory will move from some random SRAM address to the range declared in the scripts

Which builds did you run to make sure they build?

[X] arm-none-eabi-gcc Cortex M4
[ ] arm-none-eabi-gcc Cortex M7
[ ] (Apple) Native Clang
[ ] (Apple) Homebrew GCC
[ ] (Apple) Homebrew LLVM

How Do We Know and Can Show It's Fixed:

* Looked at map file to see that it's moved the DMA buffers to the right spot now.

Which Unittest Series did you Check?

[ ] (Apple) Native Clang
[ ] (Apple) Homebrew GCC
[ ] (Apple) Homebrew LLVM

Did this affect any on-target builds? If so which were tested?

[X] STM32F407VE board (boots)
[ ] STM32H753ZI board

Author: emrainey

boards/netduinoplus2/source/BoardContext.cpp

@@ -8,7 +8,7 @@
 namespace stm32 {
 
 /// @brief Dedicate a chunk of memory for the DMA buffers
-LINKER_SECTION(".dma_buffer") alignas(alignof(std::max_align_t)) static core::Array<uint8_t, DmaBlockSize * DmaBlockCount> dma_memory;
+LINKER_SECTION(".dma_buffers") alignas(alignof(std::max_align_t)) static core::Array<uint8_t, DmaBlockSize * DmaBlockCount> dma_memory;
 /// @brief Manage the DMA buffers with a bitmap allocator
 static core::BitMapHeap<DmaBlockSize, DmaBlockCount> dma_heap_allocator{&dma_memory[0], dma_memory.size()};
 

boards/stm32_f4ve_v2/source/BoardContext.cpp

@@ -12,7 +12,7 @@
 namespace stm32 {
 
 /// @brief Dedicate a chunk of memory for the DMA buffers
-LINKER_SECTION(".dma_buffer") alignas(alignof(std::max_align_t)) static core::Array<uint8_t, DmaBlockSize * DmaBlockCount> dma_memory;
+LINKER_SECTION(".dma_buffers") alignas(alignof(std::max_align_t)) static core::Array<uint8_t, DmaBlockSize * DmaBlockCount> dma_memory;
 /// @brief Manage the DMA buffers with a bitmap allocator
 static core::BitMapHeap<DmaBlockSize, DmaBlockCount> dma_heap_allocator{&dma_memory[0], dma_memory.size()};
 

build-support/share/cmake/embedded-superloop/firmware.cmake

@@ -155,7 +155,7 @@ function(add_firmware)
                 add_custom_command(
                     OUTPUT ${ARG_DISASM}
                     DEPENDS ${ARG_ELF}
-                    COMMAND ${CMAKE_OBJDUMP} -d ${ARG_ELF} -marm -C -z > ${ARG_DISASM}
+                    COMMAND ${CMAKE_OBJDUMP} -D ${ARG_ELF} -s -marm -C -z > ${ARG_DISASM}
                     COMMENT "Creating Disassembly of ${ARG_ELF}"
                 )