Uncaught SyntaxError: Invalid regular expression flags

[gossi]

We have updated our ember versions to ember-cli@~3.5.0 and ember-source to ember-source@~3.6.0-beta.2. Since them our test suite is failing because ember-auto-import generates an Uncaught SyntaxError: Invalid regular expression flags error.

See here:

Which shows up in the console:

Clicking on the /assets/client/.../tests-dev.js in the top right corner reveals the error:

That said, ember-auto-import is not a direct dependency of us (yet), but sneaked in as a transitive dependency. I tried to forbidEval but that has no effect.

I'm around in discord, hit me up. Can pair on this one.

[ef4]

Got more detail via discord, the app has the following broccoli-asset-rev options:

const isProductionLike = ['production', 'staging'].includes(EmberApp.env());
const prepend = isProductionLike && process.env.DEPLOY_PREPEND ? process.env.DEPLOY_PREPEND : '/assets/client/';

    fingerprint: {
      enabled: true,
      generateAssetMap: true,
      prepend,
      exclude: ['testem.js'],
      replaceExtensions: ['html', 'css', 'js', 'ts', 'scss'],
      extensions: ['js', 'css', 'png', 'jpg', 'gif', 'map', 'svg', 'ico', 'ttf', 'woff'],
      // there is a bug in broccoli-asset-rewrite forcing us to append a hash
      customHash: isProductionLike ? undefined : () => 'dev'
    },

My bet is a bug in broccoli-asset-rev's prepend. I will test.

[ef4]

I think this is the same as #94.

Does the error go away if you disable sourcemaps?

let app = new EmberApp(defaults, {
    sourcemaps: { enabled: false}
});

It looks like broccoli-asset-rev 3.0.0 may have the fix for the underlying bug, does that help?

[gossi]

Our yarn.lock:

broccoli-asset-rev@^3.0.0:
  version "3.0.0"
  resolved "https://registry.yarnpkg.com/broccoli-asset-rev/-/broccoli-asset-rev-3.0.0.tgz#65a28c8a062d6ee2cffd91ed2a8309e0f8253ac6"
  integrity sha512-gAHQZnwvtl74tGevUqGuWoyOdJUdMMv0TjGSMzbdyGImr9fZcnM6xmggDA8bUawrMto9NFi00ZtNUgA4dQiUBw==
  dependencies:
    broccoli-asset-rewrite "^2.0.0"
    broccoli-filter "^1.2.2"
    broccoli-persistent-filter "^1.4.3"
    json-stable-stringify "^1.0.0"
    minimatch "^3.0.4"
    rsvp "^3.0.6"

broccoli-asset-rewrite@^2.0.0:
  version "2.0.0"
  resolved "https://registry.yarnpkg.com/broccoli-asset-rewrite/-/broccoli-asset-rewrite-2.0.0.tgz#603c4a52d4c8987a2f681254436923ac0a9c94ab"
  integrity sha512-dqhxdQpooNi7LHe8J9Jdxp6o3YPFWl4vQmint6zrsn2sVbOo+wpyiX3erUSt0IBtjNkAxqJjuvS375o2cLBHTA==
  dependencies:
broccoli-filter "^1.2.3"

according to what you just said... we shouldn't see this error 😇 🤷‍♂️
I will try disabling sourcemaps tomorrow and see if the error will disappear.

[gossi]

Disabling sourcemaps didn't work.

Workaround: Fixing ember-auto-import to version 1.2.6 as suggested in #94 worked.

[lucacorti]

Ended up with this issue in production builds today again after #94. I needed both broccoli-asset-rev@^3.0.0 and ember-auto-import@1.2.6 to work around it this time.

[ef4]

I know there are other bugs in broccoli-asset-rewrite that could be causing this. One example is ember-cli/broccoli-asset-rewrite#67

[NullVoxPopuli]

It looks like this was fixed, so we're going to close it for now -- if you think this is still an issue with ember-auto-import@2.x+, please open a new issue and we'll take a look! thaaaaanks!!!! 🥳