From 09bc1da005624d5d0ff27d6a8429d00a5d1013d9 Mon Sep 17 00:00:00 2001 From: chriskrycho Date: Tue, 29 Nov 2022 01:43:47 +0000 Subject: [PATCH 1/2] Advance RFC to Stage ready-for-release --- text/0821-public-types.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/text/0821-public-types.md b/text/0821-public-types.md index 428059fe05..f1f05458a2 100644 --- a/text/0821-public-types.md +++ b/text/0821-public-types.md @@ -1,5 +1,5 @@ --- -stage: accepted +stage: ready-for-release start-date: 2022-05-23T00:00:00.000Z release-date: release-versions: @@ -8,7 +8,7 @@ teams: - typescript - learning prs: - accepted: https://github.com/emberjs/rfcs/pull/821 + accepted: 'https://github.com/emberjs/rfcs/pull/821' project-link: --- @@ -283,7 +283,7 @@ class _Transition implements Pick, 'then' | 'catch' | 'finally'> { data: Record; - readonly from: RouteInfoWithAttributes | null; + readonly from: RouteInfoWithAttributes |; readonly promise: Promise; readonly to: RouteInfo | RouteInfoWithAttributes; abort(): Transition; @@ -332,12 +332,12 @@ function takesTransition(theTransition) { ```ts export default interface RouteInfo { - readonly child: RouteInfo | null; + readonly child: RouteInfo |; readonly localName: string; readonly name: string; readonly paramNames: string[]; readonly params: Record; - readonly parent: RouteInfo | null; + readonly parent: RouteInfo |; readonly queryParams: Record; readonly metadata: unknown; find( From c15b203c93d08c833f31aed197f385a95541a13f Mon Sep 17 00:00:00 2001 From: "Ember.js RFCS CI" Date: Tue, 29 Nov 2022 01:43:51 +0000 Subject: [PATCH 2/2] Update RFC 0821 ready-for-release PR URL --- text/0821-public-types.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/text/0821-public-types.md b/text/0821-public-types.md index f1f05458a2..b860c985dc 100644 --- a/text/0821-public-types.md +++ b/text/0821-public-types.md @@ -9,6 +9,7 @@ teams: - learning prs: accepted: 'https://github.com/emberjs/rfcs/pull/821' + ready-for-release: 'https://github.com/emberjs/rfcs/pull/874' project-link: --- @@ -283,7 +284,7 @@ class _Transition implements Pick, 'then' | 'catch' | 'finally'> { data: Record; - readonly from: RouteInfoWithAttributes |; + readonly from: RouteInfoWithAttributes | null; readonly promise: Promise; readonly to: RouteInfo | RouteInfoWithAttributes; abort(): Transition; @@ -332,12 +333,12 @@ function takesTransition(theTransition) { ```ts export default interface RouteInfo { - readonly child: RouteInfo |; + readonly child: RouteInfo | null; readonly localName: string; readonly name: string; readonly paramNames: string[]; readonly params: Record; - readonly parent: RouteInfo |; + readonly parent: RouteInfo | null; readonly queryParams: Record; readonly metadata: unknown; find(