Skip to content

Commit da49b97

Browse files
Ember 3.20, update ember-fetch, bump deps (#495)
* Ember 3.20 * Update ember-fetch * Tweaks * Fix fetch, update router-scroll * Remove debuggers * Update yarn.lock * Remove dependency lint * Add fetch resolution
1 parent 70347aa commit da49b97

File tree

21 files changed

+2340
-2837
lines changed

21 files changed

+2340
-2837
lines changed

.eslintrc.js

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -67,22 +67,7 @@ module.exports = {
6767
node: true
6868
},
6969
plugins: ['node'],
70-
rules: Object.assign(
71-
{},
72-
require('eslint-plugin-node').configs.recommended.rules,
73-
{
74-
// add your custom rules and overrides for node files here
75-
}
76-
)
77-
},
78-
79-
// test files
80-
{
81-
files: ['tests/**/*.js'],
82-
excludedFiles: ['tests/dummy/**/*.js'],
83-
env: {
84-
embertest: true
85-
}
70+
extends: ['plugin:node/recommended']
8671
},
8772

8873
// node test files

.travis.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ language: node_js
33
node_js:
44
- "10"
55

6-
sudo: true
7-
dist: trusty
6+
dist: xenial
87

98
addons:
109
chrome: stable
@@ -52,9 +51,7 @@ jobs:
5251
script: yarn test:test-apps
5352

5453
- stage: versioned tests
55-
env: EMBER_TRY_SCENARIO=ember-lts-3.4
56-
- env: EMBER_TRY_SCENARIO=ember-lts-3.8
57-
- env: EMBER_TRY_SCENARIO=ember-lts-3.12
54+
env: EMBER_TRY_SCENARIO=ember-lts-3.12
5855
- env: EMBER_TRY_SCENARIO=ember-lts-3.16
5956
- env: EMBER_TRY_SCENARIO=ember-release
6057
- env: EMBER_TRY_SCENARIO=ember-beta

LICENSE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
The MIT License (MIT)
22

3-
Copyright (c) 2017
3+
Copyright (c) 2020
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
66

addon/adapters/-addon-docs.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
import Adapter from '@ember-data/adapter';
22
import config from 'ember-get-config';
3-
import { inject as service } from '@ember/service';
3+
import fetch from 'fetch';
44

55
export default Adapter.extend({
66
defaultSerializer: '-addon-docs',
77
namespace: `${config.rootURL.replace(/\/$/, '')}/docs`,
8-
docsFetch: service(),
98

109
shouldBackgroundReloadAll() {
1110
return false;
@@ -17,7 +16,7 @@ export default Adapter.extend({
1716

1817
findRecord(store, modelClass, id, snapshot) {
1918
if (modelClass.modelName === 'project') {
20-
return this.docsFetch.fetch({ url: `${this.namespace}/${id}.json` }).json();
19+
return fetch(`${this.namespace}/${id}.json`).then((response) => response.json());
2120
} else {
2221
return store.peekRecord(modelClass.modelName, id);
2322
}

addon/router.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
/** @documenter yuidoc */
22

3-
import EmberRouter from '@ember/routing/router';
4-
import RouterScroll from 'ember-router-scroll';
3+
import EmberRouterScroll from 'ember-router-scroll';
54

65
/**
76
The AddonDocsRouter, which adds some extra functionality. This should be used
@@ -20,7 +19,7 @@ import RouterScroll from 'ember-router-scroll';
2019
@class AddonDocsRouter
2120
@extends EmberRouter
2221
*/
23-
export default EmberRouter.extend(RouterScroll);
22+
export default class AddonDocsRouter extends EmberRouterScroll {}
2423

2524
/**
2625
Creates the docs route and api docs routes. Can receive a callback with the

addon/services/docs-fetch.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

addon/services/docs-search.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
1-
import Service, { inject as service } from '@ember/service';
1+
import Service from '@ember/service';
22
import { getOwner } from '@ember/application';
33
import { computed } from '@ember/object';
44
import lunr from 'lunr';
55
import config from 'ember-get-config';
6+
import fetch from 'fetch';
67

78
const { Index, Query } = lunr;
89

910
export default Service.extend({
10-
docsFetch: service(),
11-
1211
search(phrase) {
1312
return this.loadSearchIndex()
1413
.then(({ index, documents }) => {
@@ -75,7 +74,7 @@ export default Service.extend({
7574

7675
loadSearchIndex() {
7776
if (!this._searchIndex) {
78-
this._searchIndex = this.docsFetch.fetch({ url: this._indexURL }).json()
77+
this._searchIndex = fetch(this._indexURL).then((response) => response.json())
7978
.then(json => {
8079
return {
8180
index: Index.load(json.index),

addon/services/project-version.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
1-
import Service, { inject as service } from '@ember/service';
1+
import Service from '@ember/service';
22
import { getOwner } from '@ember/application';
33
import { computed } from '@ember/object';
44
import { task } from 'ember-concurrency';
55
import config from 'ember-get-config';
66
import { assign } from '@ember/polyfills';
7+
import fetch from 'fetch';
78

89
const { latestVersionName } = config['ember-cli-addon-docs'];
910

1011
export default Service.extend({
11-
docsFetch: service(),
12-
1312
_loadAvailableVersions: task(function*() {
14-
let response = yield this.docsFetch.fetch({ url: `${this.root}versions.json` }).response();
13+
let response = yield fetch(`${this.root}versions.json`);
1514
let json;
1615
if(response.ok){
1716
json = yield response.json();

config/ember-try.js

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,6 @@ module.exports = async function() {
66
return {
77
useYarn: true,
88
scenarios: [
9-
{
10-
name: 'ember-lts-3.4',
11-
npm: {
12-
devDependencies: {
13-
'ember-source': '~3.4.0'
14-
}
15-
}
16-
},
17-
{
18-
name: 'ember-lts-3.8',
19-
npm: {
20-
devDependencies: {
21-
'ember-source': '~3.8.0'
22-
}
23-
}
24-
},
259
{
2610
name: 'ember-lts-3.12',
2711
npm: {
@@ -62,16 +46,6 @@ module.exports = async function() {
6246
}
6347
}
6448
},
65-
// The default `.travis.yml` runs this scenario via `yarn test`,
66-
// not via `ember try`. It's still included here so that running
67-
// `ember try:each` manually or from a customized CI config will run it
68-
// along with all the other scenarios.
69-
{
70-
name: 'ember-default',
71-
npm: {
72-
devDependencies: {}
73-
}
74-
},
7549
{
7650
name: 'ember-default-with-jquery',
7751
env: {

package.json

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@
4646
"chalk": "^2.4.2",
4747
"ember-angle-bracket-invocation-polyfill": "^2.0.2",
4848
"ember-assign-polyfill": "^2.6.0",
49-
"ember-auto-import": "^1.5.3",
49+
"ember-auto-import": "^1.6.0",
5050
"ember-cli-autoprefixer": "^0.8.1",
51-
"ember-cli-babel": "^7.19.0",
51+
"ember-cli-babel": "^7.21.0",
5252
"ember-cli-clipboard": "^0.13.0",
5353
"ember-cli-htmlbars": "^5.2.0",
5454
"ember-cli-postcss": "^5.0.0",
@@ -60,8 +60,7 @@
6060
"ember-composable-helpers": "^2.4.0",
6161
"ember-concurrency": "^0.9.0 || ^0.10.0 || ^1.0.0",
6262
"ember-data": "2.x - 3.x",
63-
"ember-fetch": "^6.7.1",
64-
"ember-fetch-adapter": "^0.4.3",
63+
"ember-fetch": "^8.0.1",
6564
"ember-get-config": "^0.2.4",
6665
"ember-href-to": "^1.15.1",
6766
"ember-keyboard": "^4.0.0",
@@ -70,7 +69,7 @@
7069
"ember-on-modifier": "^1.0.0",
7170
"ember-responsive": "^3.0.5",
7271
"ember-router-generator": "^2.0.0",
73-
"ember-router-scroll": "^1.3.3",
72+
"ember-router-scroll": "^3.3.3",
7473
"ember-svg-jar": "^2.2.3",
7574
"ember-tether": "^1.0.0",
7675
"ember-truth-helpers": "^2.1.0",
@@ -101,20 +100,18 @@
101100
},
102101
"devDependencies": {
103102
"@ember/optional-features": "^1.3.0",
104-
"@glimmer/component": "^1.0.0",
103+
"@glimmer/component": "^1.0.1",
105104
"@glimmer/tracking": "^1.0.0",
106105
"babel-eslint": "^10.1.0",
107106
"broccoli-asset-rev": "^3.0.0",
108107
"chai": "^4.2.0",
109108
"common-tags": "^1.8.0",
110-
"ember-auto-import": "^1.5.3",
111109
"ember-classy-page-object": "^0.5.0",
112-
"ember-cli": "~3.18.0",
110+
"ember-cli": "~3.20.0",
113111
"ember-cli-addon-docs-esdoc": "^0.2.3",
114112
"ember-cli-addon-docs-yuidoc": "^0.2.4",
115113
"ember-cli-blueprint-test-helpers": "^0.19.2",
116114
"ember-cli-dependency-checker": "^3.2.0",
117-
"ember-cli-dependency-lint": "^1.1.3",
118115
"ember-cli-deploy": "^1.0.2",
119116
"ember-cli-deploy-build": "^2.0.0",
120117
"ember-cli-deploy-git": "^1.3.4",
@@ -130,13 +127,13 @@
130127
"ember-maybe-import-regenerator-for-testing": "^1.0.0",
131128
"ember-qunit": "^4.6.0",
132129
"ember-resolver": "^8.0.0",
133-
"ember-source": "~3.18.0",
130+
"ember-source": "~3.20.2",
134131
"ember-source-channel-url": "^2.0.1",
135-
"ember-template-lint": "^2.6.0",
132+
"ember-template-lint": "^2.9.1",
136133
"ember-test-selectors": "^2.1.0",
137134
"ember-try": "^1.4.0",
138-
"eslint": "^6.8.0",
139-
"eslint-plugin-ember": "^8.4.0",
135+
"eslint": "^7.5.0",
136+
"eslint-plugin-ember": "^8.9.1",
140137
"eslint-plugin-node": "^11.1.0",
141138
"loader.js": "^4.7.0",
142139
"mocha": "^6.2.3",
@@ -145,6 +142,12 @@
145142
"release-it": "^13.5.7",
146143
"release-it-lerna-changelog": "^2.3.0"
147144
},
145+
"peerDependencies": {
146+
"ember-fetch": "^8.0.1"
147+
},
148+
"resolutions": {
149+
"whatwg-fetch": "3.3.1"
150+
},
148151
"engines": {
149152
"node": "10.* || >= 12"
150153
},

0 commit comments

Comments
 (0)