Merge pull request #83 from jherdman/better-error-message-for-redis-urls

Better Error Message for Bad Redis URLs

Author: lukemelia

index.js

@@ -74,6 +74,12 @@ module.exports = {
 
         if (!this.pluginConfig.url) {
           ['host', 'port'].forEach(this.applyDefaultConfigProperty.bind(this));
+        } else {
+          var redisUrlRegexp = new RegExp('^redis://');
+
+          if (!this.pluginConfig.url.match(redisUrlRegexp)) {
+            throw new Error('Your Redis URL appears to be missing the "redis://" protocol. Update your URL to: redis://' + this.pluginConfig.url);
+          }
         }
 
         ['filePattern', 'distDir', 'keyPrefix', 'activationSuffix', 'activeContentSuffix', 'revisionKey', 'didDeployMessage', 'redisDeployClient', 'maxRecentUploads', 'revisionData'].forEach(this.applyDefaultConfigProperty.bind(this));

tests/unit/index-test.js

@@ -143,6 +143,31 @@ describe('redis plugin', function() {
 
         assert.equal(redisLib.createdClient.options, 'redis://:password@host.amazonaws.com:6379/4');
       });
+
+      it('throws if the Redis URL is missing the "redis://" protocol', function() {
+        var plugin = subject.createDeployPlugin({
+          name: 'redis'
+        });
+
+        var redisLib = new FakeRedis();
+
+        var context = {
+          ui: mockUi,
+          project: stubProject,
+          config: {
+            redis: {
+              url: 'host.amazonaws.com:6379/4'
+            }
+          },
+          _redisLib: redisLib
+        };
+
+        plugin.beforeHook(context);
+
+        assert.throws(function() {
+          plugin.configure(context);
+        }, 'Your Redis URL appears to be missing the "redis://" protocol. Update your URL to: redis://host.amazonaws.com:6379/4');
+      });
     });
 
     describe('resolving port from the pipeline', function() {