-
Notifications
You must be signed in to change notification settings - Fork 5
Let's merge #3
Description
Hi,
I published mindwave and you published mindwave2. It's been years since I worked with it, but I just got a support-request via email, and realized there is kind of a cluster of a mess around link-back and support. You submitted a PR to my repo that makes npm show your repo as the source for the package I published, but I am pretty sure I wrote the original code in my repo. You also removed the fork marker from the github repo, which obfuscates track-back for people trying to figure out "Who made this?"
Here is the merge I propose:
- Update mindwave2 on npm to point back to mindwave in README ("deprecated: use mindwave instead")
- You archive your github fork (that isn't marked as a fork) with deprecation stuff in README
- I merge any unmerged updates you have into git repo I think they are all in the original PR, and probly outdated, but we should get it all up-to-date, in either case
- I make you a maintainer of my repo so you have control of updates and can help with support, if you want.
- I publish changes to npm, so it points back to our shared repo and has all the updates it needs
It's probably not intentional, but it really feels like you were trying to strip my authorship from the library, by forking and removing the fork-linkage in github, and publishing on npm as a new package, also by modifying how package.json points back to your repo, not mine. I'm fully willing to assume this was all a series of innocent mistakes, I could see how it could happen unintentionally, for sure.
In the future, let's just totally co-maintain it in a shared repo, and we can communicate with each other directly, if we need to make changes, and little things like deps can just be updated and published.