Fix FIFO ordering for queued sync_info messages#316
Merged
josevalim merged 1 commit intoJun 30, 2025
Conversation
acco
commented
Jun 30, 2025
|
|
||
| alias GenStage.Buffer | ||
|
|
||
| describe "estimate_size/1" do |
Contributor
Author
There was a problem hiding this comment.
Happy to remove any extraneous tests not related to this commit!
| Buffer.take_count_or_until_permanent(buffer, 5) | ||
|
|
||
| assert temps == [:temp1, :temp2] | ||
| assert perms == [:perm3, :perm4, :perm5] |
Contributor
Author
There was a problem hiding this comment.
This test was failing before fix
| assert perms == [:perm3, :perm4, :perm5] | ||
| end | ||
|
|
||
| test "interleaves temporary and permanent events correctly across multiple wheel positions" do |
Contributor
Author
There was a problem hiding this comment.
this test was also failing before fix
556c6b7 to
d2e8611
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Addresses #315
The
GenStage.Buffermodule was returning permanent events in LIFO instead of FIFO order when multiple permanent events were stored at the same wheel position.Reproduction
Before fix:
[:perm_third, :perm_second, :perm_first](LIFO - wrong)After fix:
[:perm_first, :perm_second, :perm_third](FIFO - correct)Root Cause
In
pop_and_increment_wheel/1, permanent events were stored using[new_perm | existing_list], but when retrieved the list wasn't reversed to restore FIFO order.Solution
Added
:lists.reverse(perms)inpop_and_increment_wheel/1before returning permanent events, ensuring they're returned in the same order they were stored.