Support handle_continue

[palm86]

As part of the start-up of a Producer, I have a longer running piece of code that needs to execute. Doing it in the init seems wrong now that handle_continue exists. But GenStage doesn't support handle_continue. I don't know if it can/should, but it would be a useful addition.

[josevalim]

We could support it. PRs are welcome.

[josevalim]

Closing in favor of the PR.

[adherr]

I would like to use handle_continue after demand and info callbacks. I'm not in a place right now to pick up the PR. Would you like to track this in an open issue, either reopening this one or I could create a new one? Otherwise, this closed issue has enough information for someone like me who is looking for this feature.

[hazardfn]

@josevalim I am going to pick this up later today. While trying to get familiar with the project yesterday evening I noticed in the docs it is stated :hibernate on init/1 is supported as a 3rd tuple argument in the return (https://github.com/elixir-lang/gen_stage/blob/master/lib/gen_stage.ex#L837).

Looking at the init code I don't see where this is picked up and it isn't included in the type-specs - as handling for options like :hibernate at this level are related in a sense to {:continue, term} I'd like to understand if this is a misprint or I'm actually missing something fundamental in how these are handled. If it is a misprint I am also happy to fix support for :hibernate on init in a separate commit or PR depending on preference 👍

[palm86]

@hazardfn There is this abandoned PR: #234 I never got around to doing the tests, but iirc, the code "works", whatever that means without tests.

[hazardfn]

@palm86 great! This very question was answered in the PR 😄. If you have no plans to work on it further I'm happy to pick it up and finish the rest?

[palm86]

You're welcome to pick it up!

…

On Fri, 18 Sep 2020 at 14:54, Howard Beard-Marlowe ***@***.***> wrote: @palm86 <https://github.com/palm86> great! This very question was answered in the PR 😄. If you have no plans to work on it further I'm happy to pick it up and finish the rest? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#227 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXFLZL3GM4CPCSYQ5CRRLDSGNKBRANCNFSM4HDAF62A> .

[whatyouhide]

Closing again in favor of the PR #264.