fix conda env refresh not waiting for promises (microsoft#751)

This was causing the refresh function to return with empty or missing
environments before waiting for all async calls that update the env
collection.

This bug was somehow causing duplicate environments to appear in the
list of environments.

Co-authored-by: Eleanor Boyd <26030610+eleanorjboyd@users.noreply.github.com>

Author: almarouk

src/managers/conda/condaUtils.ts

@@ -694,12 +694,14 @@ export async function refreshCondaEnvs(
             .filter((e) => e.kind === NativePythonEnvironmentKind.conda);
         const collection: PythonEnvironment[] = [];
 
-        envs.forEach(async (e) => {
-            const environment = await nativeToPythonEnv(e, api, manager, log, condaPath, condaPrefixes);
-            if (environment) {
-                collection.push(environment);
-            }
-        });
+        await Promise.all(
+            envs.map(async (e) => {
+                const environment = await nativeToPythonEnv(e, api, manager, log, condaPath, condaPrefixes);
+                if (environment) {
+                    collection.push(environment);
+                }
+            }),
+        );
 
         return sortEnvironments(collection);
     }