Skip to content

Use trim-safe code in LazyJsonConverter. #8793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teo-tsirpanis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use trim-safe code in LazyJsonConverter. #8793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Elastic.Clients.Elasticsearch/_Shared/Core/LazyJsonConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@ public override LazyJson Read(ref Utf8JsonReader reader, Type typeToConvert, Jso
{
InitializeSettings(options);

#pragma warning disable IL2026, IL3050 // The `TypeInfoResolver` for `RequestResponseConverter` knows how to handle `JsonElement`.
return new LazyJson(JsonSerializer.Deserialize<JsonElement>(ref reader, options), _settings!);
#pragma warning restore IL2026, IL3050
return new LazyJson(JsonElement.ParseValue(ref reader), _settings!);
}

private void InitializeSettings(JsonSerializerOptions options)
Expand Down